fix(aws-elasticloadbalancingv2): fix load balancer deletion protection to properly update when set to false

[jericht]

Fixes #9975

Notes

• Changed load balancer deletion protection to also set the attribute to false, instead of omitting the attribute when deletionProtection is false.
• Added unit test to verify the attribute is set with false in this case
• Fixed other load balancer unit tests that were broken due to adding this attribute when deletionProtection is false
• Updated expected.json files for integ tests to include this attribute when deletionProtection is false

Main changes

• packages/@aws-cdk/aws-elasticloadbalancingv2/lib/shared/base-load-balancer.ts
• packages/@aws-cdk/aws-elasticloadbalancingv2/test/alb/load-balancer.test.ts
• packages/@aws-cdk/aws-elasticloadbalancingv2/test/nlb/load-balancer.test.ts

Changes for expected.json files

• Everything else

Testing

• Ran unit tests and ensured they succeeded
• Deploy a load balancer with deletion protection on, set it to false in CDK code, then redeploy and ensure it gets turned off

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[jericht]

Looks like multiple integration tests are affected. Will take some time to update all the snapshots.

[jericht]

@njlynch This is ready for review now

[njlynch]

Thanks for the this PR! 1 line change, 239 lines of test updates! :D

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: e296817
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).