Skip to content

Commit

Permalink
Default s3 streaming to --only-show-errors
Browse files Browse the repository at this point in the history
  • Loading branch information
kyleknap committed Sep 29, 2014
1 parent 995dc93 commit f21837a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion awscli/customizations/s3/subcommands.py
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ def _validate_streaming_paths(self):
if self.parameters['src'] == '-' or self.parameters['dest'] == '-':
self.parameters['is_stream'] = True
self.parameters['dir_op'] = False
self.parameters['quiet'] = True
self.parameters['only_show_errors'] = True
if self.parameters['is_stream'] and self.cmd != 'cp':
raise ValueError("Streaming currently is only compatible with "
"single file cp commands")
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/customizations/s3/test_subcommands.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,15 +486,15 @@ def test_validate_streaming_paths_upload(self):
cmd_params = CommandParameters(self.session, 'cp', parameters, '')
cmd_params._validate_streaming_paths()
self.assertTrue(cmd_params.parameters['is_stream'])
self.assertTrue(cmd_params.parameters['quiet'])
self.assertTrue(cmd_params.parameters['only_show_errors'])
self.assertFalse(cmd_params.parameters['dir_op'])

def test_validate_streaming_paths_download(self):
parameters = {'src': 'localfile', 'dest': '-'}
cmd_params = CommandParameters(self.session, 'cp', parameters, '')
cmd_params._validate_streaming_paths()
self.assertTrue(cmd_params.parameters['is_stream'])
self.assertTrue(cmd_params.parameters['quiet'])
self.assertTrue(cmd_params.parameters['only_show_errors'])
self.assertFalse(cmd_params.parameters['dir_op'])

def test_validate_no_streaming_paths(self):
Expand Down

0 comments on commit f21837a

Please sign in to comment.