-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow aws cloudformation package
to work with local paths in AWS::Include
transforms
#2513
Comments
Marking as feature request. @sanathkr what's your thoughts on this? |
Great idea. Let's do it. PRs please :-) |
Any luck? This would be a huge improvement of the CloudFormation workflow, which is the main obstacle of people adopting CloudFormation widely! |
Any update on this issue? It would be a fantastic feature to have. |
This would be a huge help for the use case from this example: https://github.com/awslabs/serverless-application-model/blob/master/examples/2016-10-31/api_swagger_cors/template.yaml |
Good Morning! We're closing this issue here on GitHub, as part of our migration to UserVoice for feature requests involving the AWS CLI. This will let us get the most important features to you, by making it easier to search for and show support for the features you care the most about, without diluting the conversation with bug reports. As a quick UserVoice primer (if not already familiar): after an idea is posted, people can vote on the ideas, and the product team will be responding directly to the most popular suggestions. We’ve imported existing feature requests from GitHub - Search for this issue there! And don't worry, this issue will still exist on GitHub for posterity's sake. As it’s a text-only import of the original post into UserVoice, we’ll still be keeping in mind the comments and discussion that already exist here on the GitHub issue. GitHub will remain the channel for reporting bugs. Once again, this issue can now be found by searching for the title on: https://aws.uservoice.com/forums/598381-aws-command-line-interface -The AWS SDKs & Tools Team This entry can specifically be found on UserVoice at: https://aws.uservoice.com/forums/598381-aws-command-line-interface/suggestions/33168370-allow-aws-cloudformation-package-to-work-with-lo |
Based on community feedback, we have decided to return feature requests to GitHub issues. |
this would be a major benefit as @lafiosca mentions the exact same problem i'm trying to solve :) |
@sanathkr @lafiosca @georgealton @nikolay I just submit a PR that would add this for inline swagger definitions on AWS::Serverless::Api resources. Adding it for arbitrary resources would be much more difficult, it seems this is the main use case though |
Update: I have implemented this for arbitrary include transforms, not sure about my implementation approach, here is the PR, I will close the previous one if we decide to go ahead with this #3454 |
@kyleknap @sanathkr @joguSD @stealthycoin how do i go about getting my PR for this reviewed? |
I also want this functionality. Let's get this merged! |
Looks like the PRis merged but the Issue is still open. Need to close it. |
Closing this as #3454 has been merged. |
No description provided.
The text was updated successfully, but these errors were encountered: