Feature/cf package export local swagger includes transform #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2018 16:09
… are referenced from an AWS::Include transform
Codecov Report
@@ Coverage Diff @@
## develop #3440 +/- ##
===========================================
+ Coverage 94.41% 94.42% +<.01%
===========================================
Files 169 169
Lines 13252 13266 +14
===========================================
+ Hits 12512 12526 +14
Misses 740 740
Continue to review full report at Codecov.
|
|
I opened #3454 which covers a broader case than this, will close if that PR is approved |
|
Thanks for the PR! @sanathkr can you take a look at this? |
|
no longer needed as #3454 was merged |
|
Are there any documentation of how to use this? |
|
Has this been merged? I was not able to use this feature. My packaged template still translates to DefinitionUri: s3://.... (I am using sam-translator 1.18) |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing a swagger definition for AWS::Serverless::Api resource using DefinitionUri you are unable to use cloudformation intrinsic functions. Several users have complained about this. One workaround is using AWS::Include transformation to reference a swagger doc from the inline property DefinitionBody where intrinsic functions can be used. This feature provides the same local file export for swagger documents referenced from an AWS::Include in the DefinitionBody as the existing DefinitionUri file export. Below are links to discussions where this feature has been mentioned.
aws/serverless-application-model#160
aws/serverless-application-model#8
aws/serverless-application-model#345