Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in elb register-instances-with-load-balancer with botocore==1.12.0 #3554

Closed
caboteria opened this issue Sep 10, 2018 · 3 comments
Closed
Assignees
Labels
guidance Question that needs advice or information.

Comments

@caboteria
Copy link

We've been using "aws elb register-instances-with-load-balancer" successfully for several years but recently the behavior of the command seems to have changed.

It works fine with botocore==1.10.19:

$ aws elb --version
aws-cli/1.15.19 Python/2.7.5 Linux/3.10.0-862.2.3.el7.x86_64 botocore/1.10.19
$ aws elb register-instances-with-load-balancer --instances i-0f530a0249108584b --load-balancer-name kitchen-qual
{
    "Instances": [
        {
            "InstanceId": "i-0f530a0249108584b"
        }
    ]
}

If fails with botocore==1.12.0:

$ aws elb --version
aws-cli/1.15.19 Python/2.7.5 Linux/3.10.0-862.2.3.el7.x86_64 botocore/1.12.0
$ aws elb register-instances-with-load-balancer --instances i-0f530a0249108584b --load-balancer-name kitchen-qual

Error parsing parameter '--instances': Expected: '=', received: 'EOF' for input:
i-0f530a0249108584b
                   ^
@caboteria
Copy link
Author

It works with botocore==1.11.9 so it looks like the regression was introduced with botocore==1.12.0.

@jamesls
Copy link
Member

jamesls commented Sep 10, 2018

How are you installing the AWS CLI? The CLI version locks to a specific version of botocore because sometimes we need to make coordinated changes across both repos (such as this issue).

Version 1.15.19 of the CLI that you're using should require 1.10.19 of botocore, as shown here: https://github.com/aws/aws-cli/blob/1.15.19/setup.py#L26

The latest version of the CLI (1.16.10) is the only version that calls out version 1.12.0 of botocore (https://github.com/aws/aws-cli/blob/develop/setup.py#L26), so pip wouldn't have allowed those two versions to be installed together.

@jamesls jamesls added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 10, 2018
@caboteria
Copy link
Author

Thanks for your help! We'll upgrade to awscli 1.16.10.

@no-response no-response bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 12, 2018
@no-response no-response bot reopened this Sep 12, 2018
@justnance justnance self-assigned this Sep 17, 2018
@justnance justnance added the guidance Question that needs advice or information. label Dec 7, 2018
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this issue Feb 12, 2022
… commands (aws#3554)

* support package and deploy CDK synthesized templates

* add unit testing, and integration testing

* run black

* add deploy integration testing

* fix failed integration test cases

* apply pr comments

* fix package image, check if ecr_repository is not empty

* black and use Asset parameters pattern

* apply pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information.
Projects
None yet
Development

No branches or pull requests

3 participants