You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we run out of disk space (including inodes) we keep trying to sync. We also don't throw any kind of exception when this happens. I believe the root cause if from this code snippet:
def save_file(filename, response_data, last_update):
body = response_data['Body']
etag = response_data['ETag'][1:-1]
d = os.path.dirname(filename)
try:
if not os.path.exists(d):
os.makedirs(d)
except Exception: # <---- bad
pass
We should be more selective in this case and only allow errno.EEXIST errors.
The text was updated successfully, but these errors were encountered:
The "except Exception" is too general for the makedirs
call. Instead we only catch the specific case where a directory
already exists (because a thread has already come along and created it).
Any other exception propogates.
Fixesaws#739.
jamesls
added a commit
to jamesls/aws-cli
that referenced
this issue
Apr 4, 2014
The "except Exception" is too general for the makedirs
call. Instead we only catch the specific case where a directory
already exists (because a thread has already come along and created it).
Any other exception propogates.
Fixesaws#739.
If we run out of disk space (including inodes) we keep trying to sync. We also don't throw any kind of exception when this happens. I believe the root cause if from this code snippet:
We should be more selective in this case and only allow
errno.EEXIST
errors.The text was updated successfully, but these errors were encountered: