Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent SignatureDoesNotMatch errors using s3 cp #986

Closed
tmont opened this issue Nov 6, 2014 · 3 comments · Fixed by boto/botocore#372
Closed

Intermittent SignatureDoesNotMatch errors using s3 cp #986

tmont opened this issue Nov 6, 2014 · 3 comments · Fixed by boto/botocore#372
Assignees
@jamesls
Labels
bug This issue is a bug.

Comments

@tmont
Copy link

tmont commented Nov 6, 2014

I regularly upload a bunch of local static assets (css, js, images, etc.) to S3 as part of a deployment process and occasionally during the course of running the aws s3 cp --recursive command I'll get a SignatureDoesNotMatch error.

When it happens it only happens in the middle of the process, i.e. it already successfully uploaded a dozen or so files. So I know it's not my credentials.

I can't seem to reproduce it reliably, but it's pretty annoying.
@tmont
Copy link
Author

tmont commented Nov 6, 2014

Here is some maybe relevant debug info from a failed transfer: https://gist.github.com/tmont/aeaaf521e15d83aa14e2

@jamesls
Copy link
Member

jamesls commented Nov 7, 2014

Thanks, I believe I've isolated the issue and will have a fix shortly.

@jamesls jamesls self-assigned this Nov 7, 2014
@jamesls jamesls added accepted bug This issue is a bug. and removed accepted labels Nov 7, 2014
jamesls added a commit to jamesls/botocore that referenced this issue Nov 7, 2014
@jamesls
Only set auth_path once, fixes signing errors
1a059f3 
Fixes aws/aws-cli#986

The bug was that the fix_s3_host always sets the auth_path
to the current path of the request.url.  However, in the case
of a retried request, we call fix_s3_host again which changes
the auth_path to the (already modified) request path.  This
generates an auth error.

The fix now is to check if auth_path is set, and if it is, then
we can immediately return.
jamesls added a commit to jamesls/botocore that referenced this issue Nov 7, 2014
@jamesls
Only set auth_path once, fixes signing errors
12b8553 
Fixes aws/aws-cli#986

The bug was that the fix_s3_host always sets the auth_path
to the current path of the request.url.  However, in the case
of a retried request, we call fix_s3_host again which changes
the auth_path to the (already modified) request path.  This
generates an auth error.

The fix now is to check if auth_path is set, and if it is, then
we can immediately return.
@jamesls jamesls mentioned this issue Nov 7, 2014
Merged
jamesls added a commit that referenced this issue Nov 7, 2014
@jamesls
Add #986 to the changelog
b2009fc
@tmont
Copy link
Author

tmont commented Nov 7, 2014

Thanks! When is this fix slated to be released (i.e. when can I update via pip)?

kyleknap added a commit that referenced this issue Nov 11, 2014
@kyleknap
Merge branch 'release-1.6.0'
d3e2a8f 
* release-1.6.0:
  Bumping version to 1.6.0
  Update changelog
  Fix filter bug
  Add assumerole/waiters to the config file
  Fix formatting (pep8)
  Update waiters to use the new get_waiter_model
  Update waiter code based on feedback
  Expose waiters in the CLI
  Add support for MFA when assuming a role
  Fix integ test failure
  Remove commented out code
  Initial commit of assume role cred provider
  Add #986 to the changelog
@DrStrangepork DrStrangepork mentioned this issue Nov 11, 2014
Closed
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this issue Feb 12, 2022
@rli @jfuss
docs: Fix Nodejs references in Python Cookiecutter README (aws#986)
bb1adf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesls jamesls

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only set auth_path once, fixes signing errors jamesls/botocore
2 participants
@tmont @jamesls