Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let aws_completer command account for LC_CTYPE of UTF-8 #1233

Merged
merged 1 commit into from
Mar 23, 2015

Conversation

quiver
Copy link
Contributor

@quiver quiver commented Mar 22, 2015

aws command had the same problem and was already fixed in #945.

How to Reproduce

$ uname -a
Darwin latok 14.1.0 Darwin Kernel Version 14.1.0: Thu Feb 26 19:26:47 PST 2015; root:xnu-2782.10.73~1/RELEASE_X86_64 x86_64
$ export LC_CTYPE=UTF-8
$ printenv LC_CTYPE
UTF-8
$ complete -C aws_completer aws
$ aws s3 <TAB>Traceback (most recent call last):
  File "/usr/local/bin/aws_completer", line 16, in <module>
    import awscli.completer
...
    raise ValueError, 'unknown locale: %s' % localename
ValueError: unknown locale: UTF-8

Writing an integration test was a bit too heavy for me(there's no integration test for aws_completer at the moment), so test case is not included in this PR.

`aws` command had the same problem and was already fixed in aws#945.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.77% when pulling 7348f7c on quiver:issue-945-for-aws_completer into abbff5f on aws:develop.

@jamesls
Copy link
Member

jamesls commented Mar 23, 2015

Yeah, I agree, integration tests for this would likely require something like pexpect or something similar. Thanks for the PR.

@jamesls jamesls merged commit 7348f7c into aws:develop Mar 23, 2015
@quiver quiver deleted the issue-945-for-aws_completer branch November 14, 2015 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants