Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A tentative cloudfront sign implementation, subject to refactoring #1459

Closed
wants to merge 1 commit into from

Conversation

rayluo
Copy link
Contributor

@rayluo rayluo commented Aug 19, 2015

The sign feature is there. Two helper files and their test cases would better be moved into botocore, and then this PR will be changed accordingly.

And, the code structure is still subject to change when more CloudFront commands are coming.

@jamesls
Copy link
Member

jamesls commented Aug 20, 2015

Thanks. Looks like the travis build is failing. Let's get travis passing as a next step.

@rayluo rayluo force-pushed the feature-cloudfront branch from ff9c1df to 8579d95 Compare August 23, 2015 00:57
@mtdowling
Copy link
Member

Perhaps we should add a new package instead of adding cf* files into the customizations package.

@jamesls
Copy link
Member

jamesls commented Aug 25, 2015

Hey, sorry for the delay here. Can we just get the pull request updated to move the appropriate modules to botocore? Now that we know we want to move the signing stuff to botocore, let's just go ahead and do that before reviewing this code.

Thanks!

@rayluo
Copy link
Contributor Author

rayluo commented Aug 27, 2015

Both of you are right. This tentative PR was intended to be moved to botocore since day one, so I foresaw those cf* files would be gone soon.

Now please go review its cousin in this botocore PR. When it passes the review and gets merged, I will then refactor this CLI implementation to rely on that botocore PR.

@jamesls
Copy link
Member

jamesls commented Oct 12, 2015

Closing out for now. We can reopen once we pick this work back up again.

@jamesls jamesls closed this Oct 12, 2015
@rayluo rayluo mentioned this pull request Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants