Fix ec2 pagination bug #2510
Merged
Fix ec2 pagination bug #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves aws#2452 Fixes a bug where cli json input would get processed after ec2 auto pagination injection. This was due to a subtle behavior of the event system. A handler registered at the top level without any delimiters will always be called *after* any events registered that do have delimiters regarless of when or how they were registered. The handler for --cli-input-json was registered against 'calling-command', and the handler for the ec2 pagination injection was registered against 'calling-command.ec2.operation-name'. So then even though the ec2 pagination injection was using register_last, it was being called first. The solution is to use 'calling-command.*' instead for the event that --cli-input-json is registered against. This puts it in the same pool as the other delimited handlers. This had the potential to break other handlers depending on the existing ordering, but there were very few registered to that event. Running the tests revealed no issues, however.
JordonPhillips
requested review from
dstufft,
jamesls,
stealthycoin and
kyleknap
stealthycoin
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2452
Fixes a bug where cli json input would get processed after ec2
auto pagination injection.
This was due to a subtle behavior of the event system. A handler
registered at the top level without any delimiters will always
be called after any events registered that do have delimiters
regarless of when or how they were registered.
The handler for --cli-input-json was registered against
'calling-command', and the handler for the ec2 pagination injection
was registered against 'calling-command.ec2.operation-name'. So then
even though the ec2 pagination injection was using register_last, it
was being called first.
The solution is to use 'calling-command.*' instead for the event
that --cli-input-json is registered against. This puts it in the same
pool as the other delimited handlers. This had the potential to break
other handlers depending on the existing ordering, but there were
very few registered to that event. Running the tests revealed no
issues, however.
There are four places where the event is used:
Two of those are the instances under question. Neither of the others
is dependent on
--cli-input-json.cc @kyleknap @jamesls @stealthycoin @dstufft