Update Assume Role docs and tests #2956
Conversation
awscli/topics/config-vars.rst
Outdated
| * ``source_profile`` - The AWS CLI profile that contains credentials we should | ||
| use for the initial ``assume-role`` call. | ||
| * ``source_profile`` - The AWS CLI profile that contains credentials / | ||
| configuration we should use for the initial ``assume-role`` call. This |
There was a problem hiding this comment.
Probably want to remove the use of "we" to make it more third person or instructive.
awscli/topics/config-vars.rst
Outdated
| * ``source_profile`` - The AWS CLI profile that contains credentials / | ||
| configuration we should use for the initial ``assume-role`` call. This | ||
| profile may be another profile configured to use ``assume-role``, though | ||
| if static credentials are present in the profile they will be preferred. |
There was a problem hiding this comment.
Maybe rephrase this from "preferred" to something a long the lines of taking precedence over role_arn/credential_source
awscli/topics/config-vars.rst
Outdated
| the initial ``assume-role`` call. This parameter cannot be provided | ||
| alongside ``source_profile``. Valid values are: | ||
| * ``Environment`` to pull source credentials from environment variables. | ||
| * ``Ec2InstanceMetadta`` to use the EC2 instance role as source credentials. |
There was a problem hiding this comment.
Ec2InstanceMetadta -> Ec2InstanceMetadata
| [profile crossaccount] | ||
| role_arn=arn:aws:iam:... | ||
| credential_source=Ec2InstanceMetadata | ||
|
|
There was a problem hiding this comment.
I wonder if it makes sense to explain what this example does exactly in obtaining credentials?
Codecov Report
@@ Coverage Diff @@
## develop #2956 +/- ##
========================================
Coverage 95.69% 95.69%
========================================
Files 159 159
Lines 12031 12031
========================================
Hits 11513 11513
Misses 518 518Continue to review full report at Codecov.
|
JordonPhillips
force-pushed
the
assume
branch
from
072fa4f to
ea5bf09
Compare
|
Cool. I squashed that extra doc commit. This will be merged alongside the relevant botocore pr. |
JordonPhillips
force-pushed
the
assume
branch
from
52270dc to
5497031
Compare
* Enabled ability to provide tags as list in samconfig.toml file * Removed trailing white spaces and reformatted code * Added integration test for tags as list deploy command * Added integration test for tags as string from samconfig.toml * Fixed Appveyer error by removing s3 info Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com>
This updates the assume role documentation and adds tests in response
to the assume role changes in boto/botocore#1313
It additionally adds changelog entries that will result in a minor
version bump.