Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the session profile to write when running aws configure #2972

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

joguSD
Copy link
Contributor

@joguSD joguSD commented Nov 20, 2017

Previously the command aws configure would only use the profile present in the parsed globals to pass to the ConfigFileWriter, but sourced the profile from the session everywhere else. This would cause issues when the profile is set via an environment variable as the updated values would be written to the wrong section. This updates the configure command to consistently use the profile on the session and updates the unit test to rely on the session rather than the parsed globals.

Fixes #2970

Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry please.

@codecov-io
Copy link

Codecov Report

Merging #2972 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2972      +/-   ##
===========================================
- Coverage    95.69%   95.69%   -0.01%     
===========================================
  Files          159      159              
  Lines        12036    12030       -6     
===========================================
- Hits         11518    11512       -6     
  Misses         518      518
Impacted Files Coverage Δ
awscli/customizations/configure/configure.py 100% <100%> (ø) ⬆️
awscli/clidriver.py 96.6% <0%> (-0.04%) ⬇️
awscli/customizations/emr/createcluster.py 98.23% <0%> (-0.02%) ⬇️
awscli/customizations/emr/helptext.py 100% <0%> (ø) ⬆️
awscli/customizations/emr/argumentschema.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa201d...26367cd. Read the comment docs.

@joguSD joguSD merged commit 82b5324 into aws:develop Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants