[SAM] Makes S3 Bucket parameter optional and creates bucket automatically in the deployment region #3040

heitorlessa · 2017-12-14T15:55:27Z

Hi everyone,

This PR makes it possible to omit --s3-bucket and AWS CLI will create a S3 bucket in the deployment region specified - This makes the following possible:

Ability to launch the same SAM template in multiple regions
Error out earlier if S3 Bucket and Deployment region differs instead of waiting for Cloudformation to be deployed and fail
Ability to automatically create S3 Bucket if no --s3-bucket was passed

This is a non-breaking change and those who are currently using --s3-bucket should continue to work just fine.

Usage: Deploy SAM stack in Ireland region without specifying the bucket

aws cloudformation package \
    --template-file template.yaml \
    --output-template-file packaged.yaml \
    --region eu-west-1 

aws cloudformation deploy \
    --template-file template.yaml \
    --stack-name test-sam \
    --region eu-west-1 \
    --capabilities CAPABILITY_IAM

This will create a bucket named sam-<region>-<accountId>

cc'ing contributors @sthulb @igngar

…was removed

…liant message

…ng captured by CLI either way

…ptured as part of CLI already

…_match

…ing now

heitorlessa · 2017-12-21T17:01:15Z

cc @sanathkr @jamesls

sanathkr

This is super useful. Thanks for doing it.

It might be useful to let the user control bucket name by adding another parameter --create-bucket which will optionally create a bucket with name --s3-bucket if it does not exist. If the bucket exists, this will be a no-op.

What do you think?

sanathkr · 2018-01-08T23:25:20Z

awscli/customizations/cloudformation/package.py

    def _run_main(self, parsed_args, parsed_globals):
+        region = parsed_globals.region if parsed_globals.region else "us-east-1"


Can we error out if region is not supplied? Last thing we want is surprises. If they are using AWS CLI, they have most likely set the region. So this will be raising the error for the 1% case

That’s a good idea.

That was our initial surprise when hacking that during the hackathon - If you don't supply "--region" during the package command "parsed_globals.region" will be "None" and we were expecting to be whatever was set in the AWS CLI - That's the reason we had this one-liner if.

What's set in the AWS CLI like regions for a profile (default, lab, etc.) only seems to work when you initiate a connection with a service (self._session <- contains a dict of regions set in a profile and likely use those in the absence of one).

Given that we need the region set as a parameter to run some additional logic we have two options here:

Error out if not supplied and end execution there as simple as that

Try capture the default region configured in the AWS CLI (there's gotta be an easy way other than parsing self._session from 'default' or from a 'profile' if set)

Implemented 1st option for now and commit to follow

Thoughts?

Heitor, I see your point. But give how buckets are global, this might do more harm than good.

@jamesls Do you know of any option to do Option-2 above (reliably get the Region set in their creds chain)?

sanathkr · 2018-01-08T23:25:33Z

awscli/customizations/cloudformation/package.py

-                    template_path=template_path)
+                template_path=template_path)
+
+        if (parsed_args.s3_bucket is not None):


bracket not needed

sanathkr · 2018-01-08T23:29:00Z

awscli/customizations/cloudformation/package.py

+    def _get_bucket_region(self, s3_bucket, s3_client):
+        s3_loc = s3_client.get_bucket_location(
+            Bucket=s3_bucket).get("LocationConstraint", "us-east-1")
+        return s3_loc.get


why another .get? Isn't s3_loc just a string?

It allows the function to be mocked for the tests easier.

Sanath is right.. This code seems incomplete, I'm download the latest source code and will send another commit after checking tests, etc. That part should've been:

def _get_bucket_region(self, s3_bucket, s3_client): s3_loc = s3_client.get_bucket_location(Bucket=s3_bucket) return s3_loc.get("LocationConstraint", "us-east-1")

instead of:

def _get_bucket_region(self, s3_bucket, s3_client): s3_loc = s3_client.get_bucket_location( Bucket=s3_bucket).get("LocationConstraint", "us-east-1") return s3_loc.get

sanathkr · 2018-01-08T23:29:22Z

awscli/customizations/cloudformation/package.py

+        if (parsed_args.s3_bucket is not None):
+            bucket = parsed_args.s3_bucket
+            s3_bucket_region = self._get_bucket_region(bucket, s3_client)
+            if not s3_bucket_region == region:


if s3_bucket_region is not region:

It's an exact word comparison and has to be "==" as "is not" isn't exactly the same here and can lead to surprised and make tests to fail.

sanathkr · 2018-01-09T21:35:16Z

awscli/customizations/cloudformation/package.py

+                        },
+                        "us_standard": {
+                            "Bucket": bucket,
+                            "CreateBucketConfiguration": {


I don't understand. I thought the location constraint was for non-us-standard regions. Am I missing something?

You're right - Fixed.

sthulb · 2018-01-09T22:11:57Z

I think adding the new flag would be redundant. There’s already a dry run flag to perform no-ops.

thulsimo@

heitorlessa · 2018-01-11T09:24:48Z

Thanks for all comments @sanathkr - We'll go through them by max EOW.

We discussed having that option on s3 bucket name and after considering all scenarios and trying in practice we found that it only adds more complexity -- Main idea was to make developers to remember less parameters and get going more quickly.

The ideal scenario we thought was for SAM to support a "project_name" variable of some sort, of which it'd allow the developer to have the S3 bucket automatically created and named using the project_name + uuid.

Happy to hear your thoughts on this though

heitorlessa

Implemented Sanath's suggestions and replied to other comments. One thought to be discussed though on --region flag

heitorlessa · 2018-01-11T14:39:21Z

awscli/customizations/cloudformation/package.py

+    def _get_bucket_region(self, s3_bucket, s3_client):
+        s3_loc = s3_client.get_bucket_location(
+            Bucket=s3_bucket).get("LocationConstraint", "us-east-1")
+        return s3_loc.get


Sanath is right.. This code seems incomplete, I'm download the latest source code and will send another commit after checking tests, etc. That part should've been:

def _get_bucket_region(self, s3_bucket, s3_client): s3_loc = s3_client.get_bucket_location(Bucket=s3_bucket) return s3_loc.get("LocationConstraint", "us-east-1")

instead of:

def _get_bucket_region(self, s3_bucket, s3_client): s3_loc = s3_client.get_bucket_location( Bucket=s3_bucket).get("LocationConstraint", "us-east-1") return s3_loc.get

heitorlessa · 2018-01-11T14:52:31Z

awscli/customizations/cloudformation/package.py

-                    template_path=template_path)
+                template_path=template_path)
+
+        if (parsed_args.s3_bucket is not None):


heitorlessa · 2018-01-11T14:53:30Z

awscli/customizations/cloudformation/package.py

+        if (parsed_args.s3_bucket is not None):
+            bucket = parsed_args.s3_bucket
+            s3_bucket_region = self._get_bucket_region(bucket, s3_client)
+            if not s3_bucket_region == region:


It's an exact word comparison and has to be "==" as "is not" isn't exactly the same here and can lead to surprised and make tests to fail.

heitorlessa · 2018-01-11T16:10:05Z

awscli/customizations/cloudformation/package.py

    def _run_main(self, parsed_args, parsed_globals):
+        region = parsed_globals.region if parsed_globals.region else "us-east-1"


That was our initial surprise when hacking that during the hackathon - If you don't supply "--region" during the package command "parsed_globals.region" will be "None" and we were expecting to be whatever was set in the AWS CLI - That's the reason we had this one-liner if.

What's set in the AWS CLI like regions for a profile (default, lab, etc.) only seems to work when you initiate a connection with a service (self._session <- contains a dict of regions set in a profile and likely use those in the absence of one).

Given that we need the region set as a parameter to run some additional logic we have two options here:

Error out if not supplied and end execution there as simple as that

Try capture the default region configured in the AWS CLI (there's gotta be an easy way other than parsing self._session from 'default' or from a 'profile' if set)

Implemented 1st option for now and commit to follow

Thoughts?

heitorlessa · 2018-01-11T16:10:52Z

awscli/customizations/cloudformation/package.py

+                        },
+                        "us_standard": {
+                            "Bucket": bucket,
+                            "CreateBucketConfiguration": {


You're right - Fixed.

…nt logic

codecov-io · 2018-01-11T16:20:32Z

Codecov Report

Merging #3040 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3040      +/-   ##
===========================================
+ Coverage    95.93%   96.01%   +0.08%     
===========================================
  Files          166      166              
  Lines        12610    12640      +30     
===========================================
+ Hits         12097    12136      +39     
+ Misses         513      504       -9

Impacted Files	Coverage Δ
awscli/customizations/cloudformation/package.py	`100% <100%> (+19.56%)`	⬆️
awscli/customizations/cloudformation/exceptions.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72ac99...d552634. Read the comment docs.

sanathkr · 2018-01-16T18:46:28Z

@heitorlessa Can you fix the test failures?

heitorlessa · 2018-01-16T20:31:53Z

sorry @sanathkr but which failures? I ran them before pushing the latest commits and the only one that is complaining now is a health check from Codecov that I don't know how to improve - If that's the case, any suggestions that I can go and fix?

20:27:59 ➜ aws-cli git:(sam-package-enhanced) venv:(aws-cli-hackathon) python:(🐍 aws-cli-hackathon) python -m unittest -v tests/unit/customizations/cloudformation/test_package.py
test_main (tests.unit.customizations.cloudformation.test_package.TestPackageCommand) ...
Successfully packaged artifacts and wrote output template to file ./oputput.
Execute the following command to deploy the packaged template
aws cloudformation deploy --template-file /Users/lessa/new-packaging-hackathon/aws-cli/oputput --stack-name <YOUR STACK NAME>
/Users/lessa/new-packaging-hackathon/aws-cli/tests/unit/customizations/cloudformation/test_package.py:81: DeprecationWarning: Please use assertEqual instead.
  self.assertEquals(rc, 0)

Successfully packaged artifacts and wrote output template to file ./oputput.
Execute the following command to deploy the packaged template
aws cloudformation deploy --template-file /Users/lessa/new-packaging-hackathon/aws-cli/oputput --stack-name <YOUR STACK NAME>
ok
test_main_bucket_different_deployment_region (tests.unit.customizations.cloudformation.test_package.TestPackageCommand) ... ok
test_main_empty_region_error (tests.unit.customizations.cloudformation.test_package.TestPackageCommand) ... ok
test_main_error (tests.unit.customizations.cloudformation.test_package.TestPackageCommand) ... ok
test_main_without_bucket (tests.unit.customizations.cloudformation.test_package.TestPackageCommand) ...
Successfully packaged artifacts and wrote output template to file ./oputput.
Execute the following command to deploy the packaged template
aws cloudformation deploy --template-file /Users/lessa/new-packaging-hackathon/aws-cli/oputput --stack-name <YOUR STACK NAME>

Successfully packaged artifacts and wrote output template to file ./oputput.
Execute the following command to deploy the packaged template
aws cloudformation deploy --template-file /Users/lessa/new-packaging-hackathon/aws-cli/oputput --stack-name <YOUR STACK NAME>
ok
test_write_output_to_stdout (tests.unit.customizations.cloudformation.test_package.TestPackageCommand) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.014s

OK

sanathkr · 2018-01-17T18:33:58Z

This: https://codecov.io/gh/aws/aws-cli/compare/809ddea13fabc2be61634bbb8242fec62e5b07fa...8403b76eaf7b78c113577c5705788d617b63f030

AFAIK, I think it is complaining about code coverage drop..

into sam-package-enhanced * 'sam-package-enhanced' of https://github.com/adhorn/aws-cli: refactor to increase code coverage in unit test

heitorlessa · 2018-01-20T21:04:26Z

@sanathkr Did some refactor in the original tests including mine and reached 100% according to coverage - Waiting for Codecov to kick in to update its results.

There is one conflict on exceptions.py as a new commit added a new Exception which is super simple to resolve, but although I tried resolving (commit 37d1e22) it it seems I can't due to not having write access.

New coverage results according to Coverage lib

21:18:33 ➜ aws-cli git:(sam-package-enhanced) venv:(aws-cli-hackathon) python:(🐍 aws-cli-hackathon) coverage report
Name                                                        Stmts   Miss Branch BrPart  Cover
---------------------------------------------------------------------------------------------
...
awscli/customizations/cloudformation/__init__.py                7      3      0      0    57%
awscli/customizations/cloudformation/artifact_exporter.py     193    123     46      0    29%
awscli/customizations/cloudformation/deploy.py                 74     51     20      0    24%
awscli/customizations/cloudformation/deployer.py               89     71     20      0    17%
awscli/customizations/cloudformation/exceptions.py             26      0      0      0   100%
awscli/customizations/cloudformation/package.py                72      0     18      0   100% <--- from 93.75%
awscli/customizations/cloudformation/yamlhelper.py             26     19      8      0    21%
...
---------------------------------------------------------------------------------------------
TOTAL                                                        3713   2652   1163      6    22%

Dunedan · 2018-04-11T18:08:59Z

@sanathkr Any update on this? I'd really love to see this getting merged.

* sam pipeline bootstrap (aws#2811) * two-stages-pipeline plugin * typos * add docstring * make mypy happy * removing swap file * delete the two_stages_pipeline plugin as the pipeline-bootstrap command took over its responsibility * remove 'get_template_function_runtimes' function as the decision is made to not process the SAM template during pipeline init which was the only place we use the function * sam pipeline bootstrap command * move the pipelineconfig.toml file to .aws-sam * UX - rewriting Co-authored-by: Chris Rehn <crehn@outlook.com> * UX improvements * make black happy * apply review comments * UX - rewriting Co-authored-by: Chris Rehn <crehn@outlook.com> * refactor * Apply review comments * use python way of array elements assignments * Update samcli/lib/pipeline/bootstrap/stage.py Co-authored-by: _sam <3804518+aahung@users.noreply.github.com> * apply review comments * typo * read using utf-8 * create and user a safe version of the save_config method * apply review comments * rename _get_command_name to _get_command_names * don't save generated ARNs for now, will save during init * Revert "don't save generated ARNs for now, will save during init" This reverts commit d184e164022d9560131c62a826436edbc93da189. * Notify the user to rotate periodically rotate the IAM credentials * typo * Use AES instead of KMS for S3 SSE * rename Ecr to ECR and Iam to IAM * Grant lambda service explicit permissions to thhe ECR instead of relying on giving this permissions on ad-hoc while creating the container images Co-authored-by: Chris Rehn <crehn@outlook.com> Co-authored-by: _sam <3804518+aahung@users.noreply.github.com> * sam pipeline init command (aws#2831) * sam pipeline init command * apply review comments * apply review comments * display a message that we have successfully created the pipeline configuration file(s). * doc typo * Let 'sam pipeline init' prefills pipeline's infrastructure resources… (aws#2894) * Let 'sam pipeline init' prefills pipeline's infrastructure resources' values from 'sam pipeline bootstrap' results. * save bootstrapped sateg region * make black happy * exclude non-dict keys from samconfig.get_env_names method. * Rename the pipeline 'Stage' concept to 'Environment' (aws#2908) * Rename the pipeline 'Stage' concept to 'Environment' * typo * Rename --environment-name argument to --environment * Sam pipelines ux rename ecr repo to image repository (aws#2910) * Rename ecr-repo to image-repository * UT Fixes * typo * typo * feat: Support creating pipeline files directly into . without hooks (aws#2911) * feat: Support creating pipeline files directly into . without hooks * Integration test for pipeline init and pipeline bootstrap (aws#2841) * Expose Environment._get_stack_name for integ test to predict stack name * Add integ test for pipeline bootstrap * Add init integ test * small UX improvements: (aws#2914) * small UX improvements: 1. show a message when the user cancels a bootstrapping command. 2. Don't prompt for CI/CD provider or provider templates if there is only one choice. 3. Make PipelineFileAlreadyExistsError a UserError. 4. use the Colored class instead of fg='color' when prompting a colored message. 5. Fix a bug where we were not allowing empty response for not required questions. * Fix Integration Test: We now don't ask the user to select a provider's pipeline template if there is only one * Add docs for PipelineFileAlreadyExistsError * make black happy * Sam pipelines s3 security (aws#2975) * Deny non https requests for the artifacts S3 bucket * enable bucket serverside logging * add integration tests for artifacts bucket SSL-only requests and access logging * typo * Ensure the ArtifactsLoggingBucket denies non ssl requests (aws#2976) * Sam pipelines ux round 3 (aws#2979) * rename customer facing message 'CI/CD provider' to 'CI/CD system' * add a note about what 'Environment Name' is during the pipeline bootstrap guided context * Apply suggestions from code review typo Co-authored-by: Chris Rehn <crehn@outlook.com> Co-authored-by: Chris Rehn <crehn@outlook.com> * let pipeline IAM user assume only IAM roles tagged with Role=pipeline-execution-role (aws#2982) * Adding AWS_ prefix to displayed out. (aws#2993) Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> * Add region to pipeline bootstrap interactive flow (aws#2997) * Ask AWS region in bootstrap interactive flow * Read default region from boto session first * Fix a unit test * Inform write to pipelineconfig.toml at the end of bootstrap (aws#3002) * Print info about pipelineconfig.toml after resources are bootstrapped * Update samcli/commands/pipeline/bootstrap/cli.py Co-authored-by: Chris Rehn <crehn@outlook.com> Co-authored-by: Chris Rehn <crehn@outlook.com> * List detected env names in pipeline init when prompt to input the env name (aws#3000) * Allow question.question can be resolved using key path * Pass the list of env names message (environment_names_message) into pipeline init interactive flow context * Update samcli/commands/pipeline/init/interactive_init_flow.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Fix unit test (trigger pr builds) * Fix integ test * Fix integ test Co-authored-by: Chris Rehn <crehn@outlook.com> * Adding account id to bootstrap message. (aws#2998) * Adding account id to bootstrap message. * adding docstring * Addressing PR comments. * Adding unit tests. * Fixing unit tests. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> * Cfn creds fix (aws#3014) * Removing pipeline user creds from cfn output. This maintains same user exp. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> * Ux bootstrap revamp 20210706 (aws#3021) * Add intro paragraph to bootstrap * Add switch account prompt * Revamp stage definition prompt * Revamp existing resources prompt * Revamp security prompt * Allow answers to be changed later * Add exit message for bootstrap * Add exit message for bootstrap (1) * Add indentation to review values * Add "Below is the summary of the answers:" * Sweep pylint errors * Update unit tests * Update samcli/commands/pipeline/bootstrap/guided_context.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Update samcli/commands/pipeline/bootstrap/guided_context.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Update samcli/commands/pipeline/bootstrap/guided_context.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Update samcli/commands/pipeline/bootstrap/guided_context.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Update samcli/commands/pipeline/bootstrap/guided_context.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Update samcli/commands/pipeline/bootstrap/guided_context.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Update samcli/commands/pipeline/bootstrap/guided_context.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Update samcli/commands/pipeline/bootstrap/guided_context.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Update samcli/commands/pipeline/bootstrap/cli.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Update unit tests * Add bold to other literals Co-authored-by: Chris Rehn <crehn@outlook.com> * Adding account condition for CFN execution role. (aws#3027) Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> * pipeline UX revamp 20210707 (aws#3031) * Allow running bootstrap inside pipeline init * Select account credential source within bootstrap * Add bootstrap decorations within pipeline init * Removing ip range option from bootstrap. (aws#3036) * Removing ip range option from bootstrap. * Fixing unit test from UX PR. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> * Fix toml file incorrect read/write in init --bootstrap (aws#3037) * Temporarily removing account fix. (aws#3038) Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> * Rename environment to stage (aws#3040) * Improve account source selection (aws#3042) * Fixing various cosmetics UX issues with pipeline workflow. (aws#3046) * Fixing credential to credentials * Forcing text color to yellow. * Adding new line after stage diagram. * Adding extra line after checking bootstrap message. * Renaming config -> configuration * account source -> credential source * Removing old message. * Fixing indentation in list. * Fixing bunch of indentation. * fixing f string Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> * Auto skip questions if stage detected (aws#3045) * Autofill question if default value is presented * Allow to use index to select stage names (aws#3051) * Updating message when bootstrap stages are missing. (aws#3058) * Updating message when bootstrap stages are missing. * Fixing indendation Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> * Fixing bootstrap integ tests. (aws#3061) * Fixing bootstrap integ tests. * Cleaning up some integ tests. * Using environment variables when running integ test on CI. * Using expression instead of full loop. * Adding instruction to use default profile on local. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> * Fix bootstrap test region (#3064) * Fix bootstrap region in integ test * Fix regions in non-interactive mode as well * Add more pipeline init integ test (aws#3065) * Fix existing pipeline init integ test * Add more pipeline init integ tests * Config file bug (aws#3066) * Validating config file after bootstrap stack creation. * Validating config file after bootstrap. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> * Fix pipeline init integ test because of pipelineconfig file exists (aws#3067) * Make stage name randomized to avoid race condition among multi canary runs (aws#3078) * Load number of stages from pipeline template (aws#3059) * Load number of stages from templates * Rename variable and add debug log * Add encoding to open() * Allow roles with Tag aws-sam-pipeline-codebuild-service-role to assume PipelineExecutionRole (aws#2950) * pipeline init UX: Ask to confirm when file exists (aws#3079) * Ask to confirm overriding if files already exist, or save to another directory * Add doc links (aws#3087) * Adding accidentally removed tests back. (aws#3088) Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com> Co-authored-by: elbayaaa <72949274+elbayaaa@users.noreply.github.com> Co-authored-by: Chris Rehn <crehn@outlook.com> Co-authored-by: Ahmed Elbayaa <elbayaaa@amazon.com> Co-authored-by: Tarun <c2tarun@users.noreply.github.com> Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>

RyanFitzSimmonsAK · 2023-05-03T18:40:15Z

Hi @heitorlessa, thanks for creating this PR and for your patience. Could you please rebase this PR against the latest branch for the team’s further consideration going forward?

RyanFitzSimmonsAK · 2023-05-09T20:09:07Z

Going to close this PR for the time being. If someone later decides they want to pick this up, rebase it and it will be reopened for consideration.

igngar and others added 14 commits December 6, 2017 14:00

initial commit for package enhancements - bucket creation

f51bcb2

Added first working version - Not clean code/exceptions yet

cc7794e

Added '-' between Region and Account to make it compliant as Hashing …

3d399b2

…was removed

Updated exceptions and removed initial clutter

c11c21b

Adds check on whether deployment region is equals to s3 bucket specified

191b3a2

Created up bucket creation code, removed prints and added stdout comp…

68ac314

…liant message

Removed helper function to check bucket existence as it's already bei…

c294e59

…ng captured by CLI either way

pep8 lint as per contrib docs

a645a77

Removed unnecessary exception as non-existent buckets exception is ca…

9cde45e

…ptured as part of CLI already

Fixed NameError in nose tests - typo missing self._does_deploy_region…

e5e55d3

…_match

Simplified code with _get_bucket_region to make changes "testable"

671b3db

Fixed conflicts

34080bf

Tests now pass with patched code for optional s3_bucket

39c37d3

Added additional tests to make optional bucket code to work; all pass…

7cca0fb

…ing now

sanathkr reviewed Jan 9, 2018

View reviewed changes

Lessa added 2 commits January 11, 2018 14:49

Fixed review comment on somehow incomplete .get()

548407d

Removes unnecessary brackets

34b34a0

heitorlessa commented Jan 11, 2018

View reviewed changes

Adds EmptyRegion exception, refactor region var, fix LocationConstrai…

63e5b20

…nt logic

Covers Empty Region exception recently introduced

8403b76

Lessa added 3 commits January 18, 2018 22:26

Adds test to cover boto exception s3 bucket not found

277e7a3

Includes _get_bucket_region coverage without impacting test result

00fe5c8

Ran pep8 on test_package

aab4cb1

Lessa and others added 5 commits January 18, 2018 22:31

refactor to increase code coverage in unit test

e96d568

refactor to increase code coverage in unit test

fcb21ca

Clean up, refactor even original tests to reach 100% coverage

3661e42

Merge branch 'sam-package-enhanced' of https://github.com/adhorn/aws-cli

ad77c0f

into sam-package-enhanced * 'sam-package-enhanced' of https://github.com/adhorn/aws-cli: refactor to increase code coverage in unit test

Merge branch 'develop' into sam-package-enhanced

37d1e22

typo

d552634

Dunedan mentioned this pull request Jul 12, 2018

Add template name defaults for SAM commands #3444

Draft

trevorrowe added the cloudformation package-deploy label Oct 13, 2021

kdaily added the customization Issues related to CLI customizations (located in /awscli/customizations) label Oct 13, 2021

justindho added contribution:core This is a PR that came from AWS. ready-for-review needs-rebase labels Jun 3, 2022

RyanFitzSimmonsAK closed this May 9, 2023

tim-finnigan mentioned this pull request Jul 3, 2023

Add template name defaults for SAM commands #8015

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SAM] Makes S3 Bucket parameter optional and creates bucket automatically in the deployment region #3040

[SAM] Makes S3 Bucket parameter optional and creates bucket automatically in the deployment region #3040

heitorlessa commented Dec 14, 2017

heitorlessa commented Dec 21, 2017

sanathkr left a comment

sanathkr Jan 8, 2018

sthulb Jan 9, 2018

heitorlessa Jan 11, 2018

sanathkr Jan 16, 2018

sanathkr Jan 8, 2018

heitorlessa Jan 11, 2018

sanathkr Jan 8, 2018

sthulb Jan 9, 2018

heitorlessa Jan 11, 2018

sanathkr Jan 8, 2018

heitorlessa Jan 11, 2018

sanathkr Jan 9, 2018

heitorlessa Jan 11, 2018

sthulb commented Jan 9, 2018

heitorlessa commented Jan 11, 2018

heitorlessa left a comment

heitorlessa Jan 11, 2018

heitorlessa Jan 11, 2018

heitorlessa Jan 11, 2018

heitorlessa Jan 11, 2018

heitorlessa Jan 11, 2018

codecov-io commented Jan 11, 2018 •

edited

Loading

sanathkr commented Jan 16, 2018

heitorlessa commented Jan 16, 2018

sanathkr commented Jan 17, 2018

heitorlessa commented Jan 20, 2018 •

edited

Loading

Dunedan commented Apr 11, 2018

RyanFitzSimmonsAK commented May 3, 2023

RyanFitzSimmonsAK commented May 9, 2023

		def _run_main(self, parsed_args, parsed_globals):
		region = parsed_globals.region if parsed_globals.region else "us-east-1"

[SAM] Makes S3 Bucket parameter optional and creates bucket automatically in the deployment region #3040

[SAM] Makes S3 Bucket parameter optional and creates bucket automatically in the deployment region #3040

Conversation

heitorlessa commented Dec 14, 2017

heitorlessa commented Dec 21, 2017

sanathkr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sthulb commented Jan 9, 2018

heitorlessa commented Jan 11, 2018

heitorlessa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Jan 11, 2018 • edited Loading

Codecov Report

sanathkr commented Jan 16, 2018

heitorlessa commented Jan 16, 2018

sanathkr commented Jan 17, 2018

heitorlessa commented Jan 20, 2018 • edited Loading

Dunedan commented Apr 11, 2018

RyanFitzSimmonsAK commented May 3, 2023

RyanFitzSimmonsAK commented May 9, 2023

codecov-io commented Jan 11, 2018 •

edited

Loading

heitorlessa commented Jan 20, 2018 •

edited

Loading