Cloudformation package command must resolve relative file paths when processing AWS::Include transform #4083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sam-cli#654
Description of changes:
aws cloudformation package
has the behavior where it resolves relative file paths with respect to the folder where the template is present. But for theAWS::Include
transform which was recently added (#3454), did not follow this pattern. As the result, it was resolving relative paths with respect to theos.cwd()
which is where the AWS CLI is invoked from.This PR fixes the issue. It also raises an explicit exception when the local file could not be read, so users get an immediate feedback loop when either their path is invalid or the file could not be found. This is also a pattern followed when packaging other resources.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.