Simpler shorthand for Value=foo parameters #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
This supports ``structure(scalar)`` shorthand as well as a special case for structures of a single scalar value. In this case you can just provide the argument directly, instead of as a key/value pair.
Instead of having to say `--ebs-optimized Value=true` you can just say `--ebs-optimized` or `--no-ebs-optimized`.
99% sure this is a bug in OrderedDict.
This updates the docs to support the new shorthand changes: * Don't generate examples for --param <value> (stucture(scalar)) * Don't generate examples for top level bools (--option/--no-option)
|
@garnaat Mind taking another look? I've updated the doc code to remove the example docs for the affected params (jamesls@f862758) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR that does two things.
--instance-type m1.smallinstead of--instance-type Value=m1.small)--ebs-optimized/--no-ebs-optimizedinstead of--ebs-optimized Value=true).This fixes item 1 of #484 but not item 2. Item 2 will likely be another pull request.
The only thing left is to integrate the doc generation to only document the simpler syntax.