Fix --associate-public-ip-address option for EC2 run-instances #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a --subnet-id option, we have to move the subnet ID value into the NetworkInterfaces structure we have created or we get a client error from EC2. Fixes 501.
| from awscli.arguments import CustomArgument | ||
|
|
||
| LOG = logging.getLogger(__name__) |
There was a problem hiding this comment.
LOG doesn't appear to be used anywhere.
There was a problem hiding this comment.
Leftover testing kruft. Will remove.
|
Should we have a test that verifies that if you provide a |
|
Good idea. I'll add that test. |
|
|
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user specifies a --associate-public-ip-address option and provides a --subnet-id option, we have to move the subnet ID value into the NetworkInterfaces structure we have created or we get a client error from EC2. Fixes #501.