-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow colorama upgrade #5712
Conversation
Signed-off-by: Yoan Blanc <yblanc@edgelab.ch>
Hi @greut, what's the use case for bumping the version of colorama? Thanks! |
Hi @greut, Can you please restrict the ceiling to We will double check the changes made up to that version. We also need to check our other builds to see if they need to be changed as well. Thanks! |
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Other projects where @dependabot updates aggressively the version of literally everything. Code-wise, the changes are very small. Note that your carefulness is greatly appreciated. |
Signed-off-by: Yoan Blanc <yblanc@edgelab.ch>
Codecov Report
@@ Coverage Diff @@
## develop #5712 +/- ##
========================================
Coverage 92.62% 92.62%
========================================
Files 203 203
Lines 16102 16102
========================================
Hits 14915 14915
Misses 1187 1187 Continue to review full report at Codecov.
|
Signed-off-by: Yoan Blanc <yblanc@edgelab.ch>
Can this PR be merged? The current version of colorama ( |
- drop upperbounds of colorama/docutils as they seem to be kept forever by upstream... ie colorama PR is more than a year old now: aws/aws-cli#5712
When is this PR gonna be merged? The current version of colorama |
Any updates on this PR? Many other requirements are failing because of this :( |
Many packages have started to update with colorama 0.4.4, however this unpin in stalled upstream aws/aws-cli#5712 aws/aws-cli#6522
Merged in #6893 |
Description of changes:
awscli
can be installed using the latest verison ofcolorama
.https://github.com/tartley/colorama/releases/tag/0.4.4
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.