Fix pagination with string params #689
Conversation
| type_ = 'integer' | ||
| if 'limit_key' in operation.pagination: | ||
| for param in operation.params: | ||
| if param.name == operation.pagination['limit_key']: |
There was a problem hiding this comment.
I don't think it's a safe assumption that there's always limit_key, based on the code below that does a if 'limit_key' in operation.pagination. It would be worth double checking that this is the case. Either way we should be consistent in this module.
There was a problem hiding this comment.
Is line 71 not the same as 107? I'm not sure what you mean here.
There was a problem hiding this comment.
You're right, sorry I misread the code. Disregard my previous comment.
|
Please add a test for this specific case you mention in the PR descriptions: |
|
I believe my latest changes fix all the comments above. Please take another look 😄 |
| paginate.unify_paging_params(argument_table, self.operation, | ||
| 'building-argument-table.foo.bar') | ||
| # Max items should be the same type as bar, which may not be an int | ||
| self.assertEqual('string', argument_table['max-items']._parse_type) |
There was a problem hiding this comment.
In general, we should not be testing through any internal APIs in a unittest unless there's really no other way to do so (just a general rule of thumb to keep in mind). You can use the .cli_type_name property to get this information.
|
Also, I'd say just make the
|
Fix pagination with string params. Fixes #689.
Fixes boto/botocore#243 by making sure the max items pagination param uses the same type as the parameter it is replacing.
@jamesls please review.