Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix table output for multibyte characters #721

Merged
merged 1 commit into from
Mar 26, 2014
Merged

fix table output for multibyte characters #721

merged 1 commit into from
Mar 26, 2014

Conversation

quiver
Copy link
Contributor

@quiver quiver commented Mar 26, 2014

Displaying multibyte characters fail for table outputs.

how to reproduce

# create a multibyte tags
$ aws ec2 create-tags  --resources ami-xxxxxxxx --tags  Key=Name,Value=✓
{
    "return": "true"
}
# list tag info w/ table output
$ aws ec2 describe-instances --output table
'ascii' codec can't encode characters in position 0-1: ordinal not in range(128)

@quiver
fix table output for multibyte characters
50fbaf0 
Encoding unicode text with `str` does not work
for multibyte characters.
jamesls added a commit that referenced this pull request Mar 26, 2014
@jamesls
Add changelog entry for #721
0c9a745
@jamesls jamesls merged commit 50fbaf0 into aws:develop Mar 26, 2014
@jamesls
Copy link
Member

jamesls commented Mar 26, 2014

Merged, thanks!

jamesls added a commit that referenced this pull request Apr 1, 2014
@jamesls
Merge branch 'release-1.3.5'
ec7d6fb 
* release-1.3.5:
  Bumping version to 1.3.5
  Update changelog with latest changes
  Fix failing test
  Fix issue with shadowed max-items arguments
  Update changelog with S3 endpoint fix
  Add s3 whitespace issues to changelog
  Bug fix for integ test on windows wiht py3
  Add integ tests for #718
  Use unicode escape sequence for file type
  Remove test with spaces
  Use larger range of random digits to avoid collisions in test
  Use unicode escape sequence for file type
  Add changelog entry for #721
  Update session to use single loader instance
  fix table output for multibyte characters
  Update changelog with 1.3.4 release notes
@jamesls jamesls mentioned this pull request Apr 4, 2014
Closed
@quiver quiver deleted the support-unicode-row branch November 14, 2014 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quiver @jamesls