Fix issue with scalar/non-scalar lists #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes aws#751, originally reported from: https://forums.aws.amazon.com/thread.jspa?messageID=534743򂣗 The basic issue was that we were looking at the first element in the list to determine whether or not we should handle something as a list or not. With `--query` you can have a heterogenous list so we need to check all elements, otherwise you'd get lists such as: ``` foo [{'Value': 'baz', 'Key': 'bar'}] foo [{'Value': 'baz', 'Key': 'bar'}] ```
| @@ -37,6 +37,7 @@ def format_text(self, data, stream=None): | |||
|
|
|||
| def assert_text_renders_to(self, data, expected_rendering): | |||
| rendered = self.format_text(data) | |||
| print(rendered) | |||
There was a problem hiding this comment.
Was this left in on purpose?
|
LGTM 🚢-it! |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #751, originally reported from:
https://forums.aws.amazon.com/thread.jspa?messageID=534743򂣗
The basic issue was that we were looking at the first element in the
list to determine whether or not we should handle something as a list
or not. With
--queryyou can have a heterogenous list so we needto check all elements, otherwise you'd get lists such as:
cc @danielgtaylor