-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source distribution #7668
Source distribution #7668
Conversation
Changes: * Add python interface for building from source under backends/build_system * Add autotools interface for calling the python build backend * Add requirements/lock files under requirements/ directory needed for building form source. * Add script for regenerating the requirements lock files from scratch. * add .gitignore entries for autotools
* Refresh the regenerate-lock-files script. * Referesh the lock files using the updated script. * Add a test which checks the lock files are synced with the plain requirements files.
Script to regenerate configure file uses pinned versions of automake and autotools inside a docker image to ensure consistent configure output.
When building a portable exe dist from source you will now get the distribuiton metadtata "source-exe". When building a system-sandbox dist from source you will now get the distribuiton metadtata "source-sandbox".
This makes it easier to install all of the dependencies if you do not want to --use-download-deps.
Add error message when flit_core is not installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just had one small comment.
configure.ac
Outdated
@@ -0,0 +1,58 @@ | |||
AC_CONFIG_MACRO_DIRS([m4]) | |||
AC_INIT([awscli], [2.7.31]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably update this to the current version of v2 is now. It will automatically get bumped but it would be good to see it be in sync to start.
Codecov Report
@@ Coverage Diff @@
## v2 #7668 +/- ##
=======================================
Coverage 93.03% 93.04%
=======================================
Files 354 354
Lines 37452 37452
Branches 6008 6008
=======================================
+ Hits 34845 34847 +2
+ Misses 1950 1949 -1
+ Partials 657 656 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚢
Final PR to merge the ongoing feature branch source-distribution into v2.