Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source distribution #7668

Merged
merged 21 commits into from
Feb 15, 2023
Merged

Source distribution #7668

merged 21 commits into from
Feb 15, 2023

Conversation

stealthycoin
Copy link
Contributor

Final PR to merge the ongoing feature branch source-distribution into v2.

Changes:
 * Add python interface for building from source under
   backends/build_system
 * Add autotools interface for calling the python build backend
 * Add requirements/lock files under requirements/ directory needed
   for building form source.
 * Add script for regenerating the requirements lock files from
   scratch.
 * add .gitignore entries for autotools
* Refresh the regenerate-lock-files script.
* Referesh the lock files using the updated script.
* Add a test which checks the lock files are synced with the
  plain requirements files.
Script to regenerate configure file uses pinned versions of automake
and autotools inside a docker image to ensure consistent configure
output.
When building a portable exe dist from source you will now get the
distribuiton metadtata "source-exe".

When building a system-sandbox dist from source you will now get the
distribuiton metadtata "source-sandbox".
This makes it easier to install all of the dependencies if you do not
want to --use-download-deps.
Add error message when flit_core is not installed
Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just had one small comment.

configure.ac Outdated
@@ -0,0 +1,58 @@
AC_CONFIG_MACRO_DIRS([m4])
AC_INIT([awscli], [2.7.31])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update this to the current version of v2 is now. It will automatically get bumped but it would be good to see it be in sync to start.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #7668 (79666d9) into v2 (ed713cd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               v2    #7668   +/-   ##
=======================================
  Coverage   93.03%   93.04%           
=======================================
  Files         354      354           
  Lines       37452    37452           
  Branches     6008     6008           
=======================================
+ Hits        34845    34847    +2     
+ Misses       1950     1949    -1     
+ Partials      657      656    -1     
Impacted Files Coverage Δ
awscli/botocore/credentials.py 97.50% <0.00%> (+0.10%) ⬆️
awscli/customizations/codeartifact/login.py 96.90% <0.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚢

@stealthycoin stealthycoin merged commit eb520a7 into v2 Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants