Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ruamel-yaml >= 0.17.22 #8072

Closed
wants to merge 3 commits into from
Closed

Support ruamel-yaml >= 0.17.22 #8072

wants to merge 3 commits into from

Conversation

yan12125
Copy link

@yan12125 yan12125 commented Jul 29, 2023

Issue #, if available:

N/A

Description of changes:

Some aws-cli changes are needed for ruamel-yaml 0.17.22 and 0.17.29. See individual commit messages.

This PR supersedes #8257

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@doxie-king
Copy link

any update on this PR? #5943 (comment)

@yan12125
Copy link
Author

Sorry, I didn't notice I was testing against some older version instead of the proposed upper bound 0.17.32. I pushed one more change needed for that version. A similar change was also proposed in #7967. That pull request was closed with "This is fixed in a later version of the library", but that is not exactly the case as I described in a newer upstream ticket https://sourceforge.net/p/ruamel-yaml/tickets/482/.

@yan12125 yan12125 changed the title Support ruamel-yaml 0.17.22 Support ruamel-yaml >= 0.17.22 Oct 17, 2023
@yan12125
Copy link
Author

Sorry, I didn't notice I was testing against some older version instead of the proposed upper bound 0.17.32. I pushed one more change needed for that version. A similar change was also proposed in #7967. That pull request was closed with "This is fixed in a later version of the library", but that is not exactly the case as I described in a newer upstream ticket https://sourceforge.net/p/ruamel-yaml/tickets/482/.

The issue is actually fixed with ruamel-yaml 0.17.36, so I dropped the workaround and raised the lower bound for this dependency.

* ruamel-yaml 0.17.22 comes with a style change that affects test results.
  From https://sourceforge.net/p/ruamel-yaml/code/ci/0.17.22/tree/CHANGES

> plain scalars: put single words longer than width on a line of their own, instead of after the previous line

* ruamel-yaml 0.17.29 introduces an issue with add_constructor and
  DEFAULT_MAPPING_TAG, and the issue is fixed with 0.17.36 [1], hence the
  new lower bound.

[1] https://sourceforge.net/p/ruamel-yaml/tickets/482/
@yan12125
Copy link
Author

yan12125 commented May 7, 2024

This pull request was part of efforts on keeping compatibility between aws-cli v2 and newer Python dependencies on Arch Linux. Now that I gave up maintaining aws-cli-v2 in Arch Linux repos (#8342 (comment)), the efforts are abandoned.

@yan12125 yan12125 closed this May 7, 2024
@yan12125 yan12125 deleted the ruamel-yaml-0.17.22 branch May 7, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants