Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Support request compression #8198

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Conversation

kyleknap
Copy link
Contributor

This is a port of this PR: boto/botocore#2959. There were a couple of other changes that I needed to pull in to get the tests to pass. See separate commits for these additional changes.

This is a port of this pull request from the botocore repository:
boto/botocore#2959
This is consistent with the upstream botocore project and
was changed in refactoring endpoints last year:
boto/botocore@357d5a8
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b15a961) 93.13% compared to head (41299f4) 93.14%.

Additional details and impacted files
@@           Coverage Diff            @@
##               v2    #8198    +/-   ##
========================================
  Coverage   93.13%   93.14%            
========================================
  Files         363      364     +1     
  Lines       38375    38481   +106     
  Branches     6146     6167    +21     
========================================
+ Hits        35741    35842   +101     
- Misses       1963     1967     +4     
- Partials      671      672     +1     
Files Coverage Δ
awscli/botocore/args.py 100.00% <100.00%> (ø)
awscli/botocore/client.py 96.71% <100.00%> (+0.01%) ⬆️
awscli/botocore/config.py 100.00% <ø> (ø)
awscli/botocore/configprovider.py 91.42% <100.00%> (ø)
awscli/botocore/model.py 98.61% <100.00%> (+<0.01%) ⬆️
awscli/botocore/compress.py 98.68% <98.68%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyleknap kyleknap removed the request for review from nateprewitt September 25, 2023 21:32
@kyleknap kyleknap merged commit 8baf8b5 into aws:v2 Sep 25, 2023
24 checks passed
@kyleknap kyleknap deleted the v2-gzip-request-compression branch September 25, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants