Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #834 #835

Merged
merged 2 commits into from
Jul 7, 2014
Merged

Fixes issue #834 #835

merged 2 commits into from
Jul 7, 2014

Conversation

jlopex
Copy link
Contributor

@jlopex jlopex commented Jul 2, 2014

Rewrite wait_for_upload_id function so UploadCancelledError is raised
when state is _CANCELLED, previous logic didn't raise UploadCancelledError
if upload_id was set.

Fixes issue #834
05ec58d 
Rewrite wait_for_upload_id function so UploadCancelledError is raised
when state is _CANCELLED, previous logic didn't raise UploadCancelledError
if upload_id was set.
@jamesls
Copy link
Member

jamesls commented Jul 2, 2014

Thanks for the PR. Would you mind writing a unit test in tests/unit/customizations/s3/test_tasks.py that demonstrates this problem? That way we can ensure we don't regress on this issue in the future.

@jamesls jamesls added the pending label Jul 2, 2014
Added test_cancel_after_upload_id to test_tasks
a65b231 
This test creates an upload_task, sets the upload_id, and then cancels the upload.

At this point any call to wait_for_upload_id must raise an UploadCancelledError,
even if a valid upload_id is set on the MultipartUploadContext object.
@jlopex
Copy link
Contributor Author

jlopex commented Jul 4, 2014

Done! Cheers!

@jamesls
Copy link
Member

jamesls commented Jul 7, 2014

Perfect, thanks!

@jamesls jamesls merged commit a65b231 into aws:develop Jul 7, 2014
@jamesls jamesls mentioned this pull request Jul 8, 2014
Closed
@diehlaws diehlaws added pr:work-in-progress This PR is a draft and needs further work. and removed pending labels Jan 4, 2019
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
@ndobryanskyy @sriram-mv
fix: Flush stdout and stderr on each write when debugging (aws#843)
c849e3c 
* Introduce StreamWriter to wrap output streams. Fix aws#835

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlopex @jamesls @diehlaws