Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Example 6 title for aws s3 sync help doc #8638

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

nasir-rabbani
Copy link
Contributor

Issue #, if available:

Description of changes:

The Example 6 title was not matching the description and example. I assume it was a copy paste issue.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The Example 6 title was not matching the description and example. I assume it was a copy paste issue.
@nasir-rabbani nasir-rabbani changed the base branch from develop to v2 April 18, 2024 13:01
@nasir-rabbani
Copy link
Contributor Author

Made the PR point to v2 now, I am not sure if the base needs to be develop or v2.

@elysahall elysahall self-requested a review December 10, 2024 18:14
@elysahall elysahall self-assigned this Dec 10, 2024
@elysahall elysahall added documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work. labels Dec 10, 2024
Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sending for maintainer review

@elysahall elysahall removed their assignment Dec 10, 2024
@elysahall elysahall added pr:needs-review This PR needs a review from a Member. and removed pr:work-in-progress This PR is a draft and needs further work. labels Dec 10, 2024
@ashovlin ashovlin changed the base branch from v2 to develop December 19, 2024 14:38
@ashovlin ashovlin merged commit c629426 into aws:develop Dec 19, 2024
@ashovlin
Copy link
Member

Thanks for the contribution @nasir-rabbani ! I merged this to develop for V1, then copied to V2 via #9152.

aws-sdk-python-automation added a commit that referenced this pull request Dec 19, 2024
* release-1.36.26:
  Bumping version to 1.36.26
  Update changelog based on model updates
  Update `Example 6` title for `aws s3 sync` help doc (#8638)
  Add GitHub Workflow for syncing PRs from `develop` to `v2` (#9142)
  CLI examples cloudfront, cognito-idp, ec2, ecr-public, ecs, inspector2, ivs-realtime, s3api, workmail (#8960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. pr:needs-review This PR needs a review from a Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants