Enabled --page-size as global argument.
#889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -546,6 +546,8 @@ def invoke(self, operation_object, parameters, parsed_globals): | |||
| endpoint_url=parsed_globals.endpoint_url, | |||
| verify=parsed_globals.verify_ssl) | |||
| if operation_object.can_paginate and parsed_globals.paginate: | |||
| if getattr(parsed_globals, 'page_size', None): | |||
There was a problem hiding this comment.
why is getattr() needed here? If it's a global arg you should just be able to access parsed_globals.page_size directly right?
There was a problem hiding this comment.
Some of the unit test failed via a key error when I did not use getattr(). I am going to change it and see if the unit tests need to be updated or something else.
There was a problem hiding this comment.
Yeah the test just needed to be updated.
|
Overall looks good, just a few questions above. |
The page size controls the amount of items returned by each page while paginating. Smoke tests were added for ``ec2`` and ``s3api`` to ensure the parameter does what is expected to do for known paginating operations.
|
Changes based on comments are in the latest commit |
|
|
Looks good.
kyleknap
added a commit
that referenced
this pull request
Aug 21, 2014
Enabled ``--page-size`` as global argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page size controls the amount of items returned by
each page while paginating. Smoke tests were added for
ec2and
s3apito ensure the parameter does what is expected todo for known paginating operations.
cc @jamesls @danielgtaylor