The configure command writes out cred vars to shared credentials file #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up the code a bit before making feature changes.
Fixes aws#847. The change is implemented as specified in the issue: * Anytime you set credential variables (access_key/secret_key/session_token) using the `configure` command or the `configure set` command, the values are always written to `~/.aws/credentials`. * Getting access_key/secret_key/session_token will look in the shared credentials file first before looking in the CLI config file. This does *not* do anything with automatically migrating over to the shared credentials file, that is, if you have credentials in the CLI config file and you run `aws configure` and hit enter 4 times, we will not write out values to the shared credentials file because there are no new values to write out.
|
LGTM |
| be created. Any parent directories will also be created | ||
| if necessary. | ||
| * If the section to update does not exist, it will be created. | ||
| * Any existing lines that specified by ``new_values`` |
There was a problem hiding this comment.
Grammar: are specified?
|
LGTM 🚢-it! |
|
Thanks, I'll get this feedback incorporated and merge to develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #847. The change is implemented as specified in the issue:
using the
configurecommand or theconfigure setcommand, thevalues are always written to
~/.aws/credentials.shared credentials file first before looking in the CLI config file.
This does not do anything with automatically migrating over to the
shared credentials file, that is, if you have credentials in the CLI
config file and you run
aws configureand hit enter 4 times, wewill not write out values to the shared credentials file because
there are no new values to write out.
cc @danielgtaylor @kyleknap