Errors and warnings are printed to stderr. #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknap
force-pushed
the
errors-to-stderr
branch
from
8ad1152 to
144e6bb
Compare
| @@ -274,13 +274,15 @@ def run(self): | |||
|
|
|||
| def _process_print_task(self, print_task): | |||
| print_str = print_task.message | |||
| print_to_stderr = False | |||
There was a problem hiding this comment.
With the newly added lines here, this method is now 62 lines long. Let's split this up to make it easier to manage.
|
Just some minor code cleanup and unit test changes above. Otherwise looks good. |
|
@jamesls I updated the code to the suggestions you made except for the ones that I pushed back a little on like the use of |
kyleknap
force-pushed
the
errors-to-stderr
branch
from
7c7da31 to
184898b
Compare
|
|
Looks good.
kyleknap
added a commit
that referenced
this pull request
Sep 25, 2014
Errors and warnings are printed to stderr.
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #820
cc @jamesls @danielgtaylor