Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libs to support Apple silicon #164

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Update libs to support Apple silicon #164

merged 3 commits into from
Jul 14, 2022

Conversation

astaticvoid
Copy link
Contributor

@astaticvoid astaticvoid commented Jul 13, 2022

Issue #, if available:
#131

Description of changes:

  • Update libs and change env-test to support running on M1 Macs.
  • Re-use mocks and linter if present to prevent unnecessary traffic.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #164 (b30063e) into main (24c96f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   74.05%   74.05%           
=======================================
  Files          15       15           
  Lines        1453     1453           
=======================================
  Hits         1076     1076           
  Misses        300      300           
  Partials       77       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c96f3...b30063e. Read the comment docs.

kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controller-gen removes this between version 0.8 and 0.9.2. It's a bug that it was being added:
kubernetes-sigs/controller-tools#456
kubernetes-sigs/controller-tools#63

@astaticvoid astaticvoid merged commit b91fe75 into aws:main Jul 14, 2022
@astaticvoid astaticvoid deleted the arm branch July 14, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants