Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SendHandler does not populate the HTTPResponse #32

Open
odannyc opened this issue Mar 24, 2021 · 3 comments
Open

SendHandler does not populate the HTTPResponse #32

odannyc opened this issue Mar 24, 2021 · 3 comments

Comments

@odannyc
Copy link

odannyc commented Mar 24, 2021

This library is not adding the HTTPResponse once we send off the request via the SendHandler. Look at the original aws-sdk-go for an example:

https://github.com/aws/aws-sdk-go/blob/main/aws/corehandlers/handlers.go#L112

@odannyc
Copy link
Author

odannyc commented Mar 25, 2021

@ktseytlin @kevinchristen

Can you guys provide some input on this?

I have other handlers that rely on HTTPResponse to be there and unfortunately this is not including it.

related:
newrelic/go-agent#287

@kevinchristen
Copy link
Contributor

DAX does not use HTTP. Can you give us more information about how your application relies on the response?

@odannyc
Copy link
Author

odannyc commented Mar 30, 2021

Thank you for responding back. There is a library (NewRelic) I'm using for tracing that relies on that field to be populated. Here is the code:

https://github.com/newrelic/go-agent/blob/master/_integrations/nrawssdk/v1/nrawssdk.go#L26-L29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants