Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with nil HttpResponse causing panics #291

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Fixes issue with nil HttpResponse causing panics #291

merged 1 commit into from
Apr 16, 2021

Conversation

odannyc
Copy link
Contributor

@odannyc odannyc commented Mar 30, 2021

Links

#287
aws/aws-dax-go#32

Details

During the endSegment handler we need to check if HTTPResponse is populated. This prevents us from nil dereference panicking when requests to AWS services don't use HTTP such as DAX

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@odannyc odannyc mentioned this pull request Apr 16, 2021
Closed
@RichVanderwal RichVanderwal linked an issue Apr 16, 2021 that may be closed by this pull request
"nil dereference" when using DAX #287
Closed
nr-swilloughby
nr-swilloughby approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@nr-swilloughby nr-swilloughby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this code change.

@nr-swilloughby nr-swilloughby merged commit 198c033 into newrelic:master Apr 16, 2021
@RichVanderwal RichVanderwal added this to the Apr Go agent release milestone Apr 29, 2021
@rittneje rittneje mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nr-swilloughby nr-swilloughby nr-swilloughby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Apr Go agent release
Development

Successfully merging this pull request may close these issues.

"nil dereference" when using DAX
4 participants
@odannyc @CLAassistant @nr-swilloughby @RichVanderwal