Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo Dotnet Publish #120

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Echo Dotnet Publish #120

merged 1 commit into from
Jul 14, 2020

Conversation

tmakin
Copy link
Contributor

@tmakin tmakin commented May 3, 2020

Issue
I had an issue with lambda deployment caused by the failure of dotnet publish. However, I was unable to replicate the problem by calling dotnet publish manually. In order to debug the issue, I added an additional log statement to output the publish args being used internally by the lambda tool. In my case, it was nuget package resolution issues that only showed when the --runtime linux-x64 arg was used.

I think my change would be a useful addition for others in order to help debug publish failures.

Changes

  • Added additional log statement to LambdaDotNetCLIWrapper.Publish

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tmakin tmakin marked this pull request as ready for review May 3, 2020 15:17
@tmakin tmakin closed this May 8, 2020
@tmakin tmakin reopened this May 8, 2020
@tmakin tmakin marked this pull request as draft May 8, 2020 15:42
@tmakin
Copy link
Contributor Author

tmakin commented May 8, 2020

Hi team, is there any way I can see the build error so I can fix the PR?

@normj normj changed the base branch from master to dev July 14, 2020 17:22
@normj normj marked this pull request as ready for review July 14, 2020 17:23
@normj normj merged commit 44edcdf into aws:dev Jul 14, 2020
@normj
Copy link
Member

normj commented Jul 14, 2020

Thanks for the PR. I merged it into the dev branch to go out with the next release. Don't worry about the CodeBuild failure, I need to get that removed from GitHub as the CodeBuild job isn't used or exist anymore.

@tmakin
Copy link
Contributor Author

tmakin commented Jul 14, 2020

Thanks @normj. I originally included some suggestions for the contributing guide in the PR, but I removed when I was trying to get rid of the CodeBuild error. Please have a read of my notes here, and if you think it would help others then I'll submit another PR:
https://github.com/tmakin/aws-extensions-for-dotnet-cli/blob/contributing-update/CONTRIBUTING.md#local-tool-development

@normj
Copy link
Member

normj commented Jul 14, 2020

I like the local tool development section. I would accept that as a PR.

@normj
Copy link
Member

normj commented Jul 22, 2020

Version 4.1.0 of Amazon.Lambda.Tools went out today with this PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants