Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed random manifest names causing zip package hash refresh on every build #163

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

aohotnik
Copy link

Issue #, if available:
#162

Description of changes:
I changed use of temporary filename for layer manifest to be directory name instead. All layers of the project will have their filename built from layer name and version number, located under the new temp directory. This stops hash of zip package to change across executions of package-ci and deploy-serverless commands when no other content changes are introduced.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj normj changed the base branch from master to dev March 24, 2021 17:24
@normj
Copy link
Member

normj commented Mar 24, 2021

Interesting, I didn't realize the name of the manifest file was being put in the deps.json file. Nice find.

@normj normj merged commit b39de8a into aws:dev Mar 24, 2021
@normj
Copy link
Member

normj commented Mar 24, 2021

This PR was shipped as part of Amazon.Lambda.Tools 5.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants