Fix issue related to yaml templates containing intrinsic functions in the short form #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. I'm finishing up another pull request #38 where I reworked a lot of how the template deployment work and the files are moved around. I'll manually merge your changes into that PR. |
normj
added a commit
that referenced
this pull request
Oct 12, 2018
… the short form This is a manual merge of PR #39 by Albert Szilvasy(szilvaa) because the PR 38 caused too many conflicts
|
I have manually merged this change along with the other PR into the Dev branch 1305565 I'll close this PR once the change is released. |
|
Released as part of version 3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#32
Description of changes:
I'm fixing the above issue by taking the latest YamlDotNet package that fixes this issue.
I've added a new unit test to ensure that this bug stays fixed.
I've also improved debuggability by logging to debugger in debug builds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.