Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "--version-label" switch to provide the ability to specify a version tag for the deployed version of code. #8

Merged
merged 1 commit into from Mar 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 13, 2018

This is related to the issue #7.

Description of changes:

  • In EBDefinedCommandOptions added a CommandOption with "--version-label" switch;
  • Added it to options list of DeployEnvironmentCommand;
  • Added VersionLabel property to DeployEnvironmentProperties;
  • In DeployEnvironmentProperties added lines of code responsible for parsing the option;
  • In DeployEnvironmentCommand now using VersionLabel parameter, and if it isn't specified - using default value (DateTime.Now.Ticks.ToString()).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj
Copy link
Member

normj commented Mar 13, 2018

Pull request looks good and i have queued up for our next release. I'll try and get that release out soon. Thanks for the pull request. This PR will get closed once the change is shipped.

@normj
Copy link
Member

normj commented Mar 14, 2018

Version 1.1.2 of Amazon.ElasticBeanstalk.Tools has been pushed with this pull request. Thanks for the pull request.

@ghost
Copy link
Author

ghost commented Mar 15, 2018

Happy to be useful! Thanks for how quickly it got published 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants