Make periodic jobs service requests disabled by default #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtalreja-a
reviewed
Jan 22, 2021
| { | ||
| errx( 1, "fatal error" ); | ||
| } | ||
| errx( 1, "fatal error" ); | ||
| } | ||
|
|
||
| if( sendStartNext( h ) == false ) |
There was a problem hiding this comment.
sendStartNext is a POST api which scales separate from Describe Job with $next as the ID which is a GET api. sendStartNext transactions will compete with the Update api which might result in throttling at scale.
There was a problem hiding this comment.
The jobs library only uses MQTT.
There was a problem hiding this comment.
Apologies - I meant to say that the category of the API is for modification instead of retrieval. SendStartNext and DescribeJob are handled and scaled differently.
There was a problem hiding this comment.
I'll try to understand this better. Any such changes will merit a new PR.
yourslab
reviewed
Jan 22, 2021
yourslab
approved these changes
Jan 22, 2021
n9wxu
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid possible throttling when scaling up code based on this demo, jobs polling and repeated job updates are tied to command line arguments and disabled by default. This PR also drops redundant subscriptions.