Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating self managed Windows Nodes #241

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

abhipth
Copy link
Contributor

@abhipth abhipth commented Oct 12, 2021

Description of changes: Adding support for creating self managed NodeGroup with EKS Cluster.

Testing

  1. make build
Success! Your shiny new binaries are ready.
find ./bin -type f
  1. Create Windows NodeGroup
AWS_K8S_TESTER_EKS_REGION=us-west-2 \
AWS_K8S_TESTER_EKS_LOG_COLOR=true \
AWS_K8S_TESTER_EKS_S3_BUCKET_CREATE=true \
AWS_K8S_TESTER_EKS_S3_BUCKET_CREATE_KEEP=false \
AWS_K8S_TESTER_EKS_ADD_ON_NODE_GROUPS_ENABLE=true \
AWS_K8S_TESTER_EKS_ADD_ON_NODE_GROUPS_ROLE_CREATE=true \
AWS_K8S_TESTER_EKS_ADD_ON_NODE_GROUPS_FETCH_LOGS=false \
AWS_K8S_TESTER_EKS_ADD_ON_NODE_GROUPS_ASGS='{"GetRef.Name-ng-al2-cpu":{"name":"GetRef.Name-ng-al2-cpu","remote-access-user-name":"ec2-user","ami-type":"AL2_x86_64","image-id":"","image-id-ssm-parameter":"/aws/service/eks/optimized-ami/1.17/amazon-linux-2/recommended/image_id","instance-types":["c5.xlarge"],"volume-size":40,"asg-min-size":2,"asg-max-size":2,"asg-desired-capacity":2,"kubelet-extra-args":""},"GetRef.Name-ng-windows":{"name":"GetRef.Name-ng-windows","remote-access-user-name":"ec2-user","ami-type":"WINDOWS_SERVER_CORE_2019_x86_64","image-id":"","image-id-ssm-parameter":"/aws/service/ami-windows-latest/Windows_Server-2019-English-Core-EKS_Optimized-1.17/image_id","instance-types":["c5.xlarge"],"volume-size":40,"asg-min-size":1,"asg-max-size":1,"asg-desired-capacity":1,"kubelet-extra-args":""}}' \
./bin/aws-k8s-tester-latest-darwin-amd64 eks create cluster --enable-prompt=true -p /tmp/cluster-with-windows-nodegroup.yaml

Formatted JSON

   "GetRef.Name-ng-windows":{
      "name":"GetRef.Name-ng-windows",
      "remote-access-user-name":"ec2-user",
      "ami-type":"WINDOWS_SERVER_CORE_2019_x86_64",
      "image-id":"",
      "image-id-ssm-parameter":"/aws/service/ami-windows-latest/Windows_Server-2019-English-Core-EKS_Optimized-1.17/image_id",
      "instance-types":[
         "c5.xlarge"
      ],
      "volume-size":40,
      "asg-min-size":1,
      "asg-max-size":1,
      "asg-desired-capacity":1,
      "kubelet-extra-args":""
   }
}
  1. Create Cluster Result
aws-k8s-tester eks create cluster SUCCESS
  1. Get All Nodes
ip-10-0-101-101.us-west-2.compute.internal   Ready    <none>   5m44s   v1.17.17-eks-104f5d   10.0.101.101   34.218.252.82   Windows Server 2019 Datacenter   10.0.17763.2114                 docker://20.10.6
ip-10-0-164-249.us-west-2.compute.internal   Ready    <none>   10m     v1.17.17-eks-ac51f2   10.0.164.249   54.212.30.87    Amazon Linux 2                   4.14.248-189.473.amzn2.x86_64   docker://20.10.7
ip-10-1-185-206.us-west-2.compute.internal   Ready    <none>   10m     v1.17.17-eks-ac51f2   10.1.185.206   35.86.124.27    Amazon Linux 2                   4.14.248-189.473.amzn2.x86_64   docker://20.10.7

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx

@abhipth abhipth merged commit 408858d into aws:main Oct 12, 2021
@abhipth abhipth deleted the windows-ng branch October 12, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants