Support Cloudwatch Events #16
Comments
|
6 months and nothing??? Where can we find what a Cloud Scheduled Event Object should look like so we can create our own class?? |
|
Sorry, we haven't made a lot of progress on this one. The problem is the detail section of the message differs for every service that sends events. Plus you can also have custom events. Also there is not one page that describes what the event looks like for all of the services. I have debated about doing something like: public class ECSEventDetail
{
public string ClusterArn {get;set;}
...
}
public class CloudWatchevent<T>
{
public string Version {get;set;}
...
public T Detail {get;set;}
}
public async Task LambdaFunction(CloudWatchEvent<ECSEventDetail> event, ILambdaContext context)
{
...
}I think this would solve the problem but we would run the risk of the detail event objects getting out of date or we would be missing some detail events. If the community is okay with this. I can add the package. Pull request would be greatly appreciated to help keep the detail events updated. |
|
@normj I liked your comment about making this a generic class. For the time being you should have to supply your own class. If others want to make PRs for the different types of "Detail" then that would be great, however, I'm in favor of getting this in at least. The PR #299 should cover the basics including deserializing "DetailType". Also it has examples for different detail types documented. |
|
Great job @exocom ! would it be possible to change it so there is a non-generic base class that doesn't offer the Details property and a generic subclass with the generic Details property? This would allow those that only need to react to the event with no interest to the details to use this class with no extra coding. example public class CloudWatchevent
{
....
}
public async Task LambdaFunction(CloudWatchEvent event, ILambdaContext context)
{
...
}
public class CloudWatchevent<T> : CloudWatchevent
{
public T Detail {get;set;}
}
public class ECSEventDetail
{
public string ClusterArn {get;set;}
...
}
public async Task LambdaFunction(CloudWatchEvent<ECSEventDetail> event, ILambdaContext context)
{
...
} |
|
@Kralizek I found a useful documentation page which made me realize a way to do this in an extensible manor. I also found another documentation page that has 27 events with their specific Detail Objects IE the schemas. Like your idea, but want to offer a solution that is flexible enough to receive multiple types of events. So how about an interface with concrete classes? I believe it would satisfy most use cases. // All events 27 total, which conform to a common Interface.
// https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/EventTypes.html
namespace Amazon.Lambda.CloudWatchEvents
{
// https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/CloudWatchEventsandEventPatterns.html
public interface ICloudWatchEvent<T>
{
string Version { get; set; }
string Account { get; set; }
string Region { get; set; }
T Detail { get; set; }
string DetailType { get; set; }
string Source { get; set; }
DateTime Time { get; set; }
string Id { get; set; }
List<string> Resources { get; set; }
}
}
namespace Amazon.Lambda.ScheduledEvents
{
// Scheduled Event
// https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/EventTypes.html#schedule_event_type
public class Detail
{
}
public class ScheduledEvent : ICloudWatchEvent<Detail>
{
public string Version { get; set; }
public string Account { get; set; }
public string Region { get; set; }
public Detail Detail { get; set; }
public string DetailType { get; set; }
public string Source { get; set; }
public DateTime Time { get; set; }
public string Id { get; set; }
public List<string> Resources { get; set; }
}
}
namespace Amazon.Lambda.ECSEvents
{
// ECS Event
// https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs_cwe_events.html
public class Attribute
{
public string Name { get; set; }
}
public class RegisteredResource
{
public string Name { get; set; }
public string Type { get; set; }
public int IntegerValue { get; set; }
public List<object> StringSetValue { get; set; }
}
public class RemainingResource
{
public string name { get; set; }
public string type { get; set; }
public int integerValue { get; set; }
public List<object> stringSetValue { get; set; }
}
public class VersionInfo
{
public string AgentHash { get; set; }
public string AgentVersion { get; set; }
public string DockerVersion { get; set; }
}
public class Detail
{
public bool AgentConnected { get; set; }
public List<Attribute> Attributes { get; set; }
public string ClusterArn { get; set; }
public string EontainerInstanceArn { get; set; }
public string Ec2InstanceId { get; set; }
public List<RegisteredResource> RegisteredResources { get; set; }
public List<RemainingResource> RemainingResources { get; set; }
public string Status { get; set; }
public int Version { get; set; }
public VersionInfo VersionInfo { get; set; }
public DateTime UpdatedAt { get; set; }
}
public class ECSEvent : ICloudWatchEvent<Detail>
{
public string Version { get; set; }
public string Id { get; set; }
public string DetailType { get; set; }
public string Source { get; set; }
public string Account { get; set; }
public DateTime Time { get; set; }
public string Region { get; set; }
public List<string> Resources { get; set; }
public Detail Detail { get; set; }
}
}
// ... Other 25 events get concrete classes.If you only have 1 Event Type public async Task LambdaFunction(ScheduledEvent @event, ILambdaContext context)
{
...
}If you have multiple Event Types public void LambdaFunction(ICloudWatchEvent<object> @event)
{
switch(@event.DetailType) {
case "ECS Task State Change":
var ecsEvent = JsonConvert.DeserializeObject<ECSEvent>(@event);
break;
case null:
break;
}
...
}If you have custom CloudWatch Event public class CustomDetail {
public string Name { get; set; }
}
public void LambdaFunction(ICloudWatchEvent<CustomDetail> @event)
{
var isKalarrs = @event.Detai.Name == "kalarrs";
...
}If you have your own custom Event public class CustomData {
public string Name { get; set; }
}
public void LambdaFunction(CustomData @event)
{
var isKalarrs = @event.Name == "kalarrs";
...
} |
|
I see where you are coming from. I personally dislike using interfaces in this case because I find them semantic-rich in a operation-based context. Also I am not convinced about having a ’Details’ property void of any semantic in the "quick to use" case. Just my 2c, but please wait for an opinion from the maintainers. |
diehlaws
added
feature-request
I'd like to officially support events like described here: https://aws.amazon.com/blogs/compute/monitor-cluster-state-with-amazon-ecs-event-stream/
The text was updated successfully, but these errors were encountered: