Added scheduled event #299
Conversation
…implment interface. Also created the ECS Event. Leaving 25 other events up to others to contribute.
|
Sorry I haven't responded sooner. Trying to clear a few other things off my plate then I'll take a deeper look. I do appreciate the PR. |
|
Is there a reason not to use a base class instead only having an interface? With only the interface we have to copy everyone of the those top level properties for each event type which there are a lot. I'm also wondering if we could just have one CloudWatch Logs project which has the interface, base class and a collection of implementations like the ECS classes you have. That would make it much easier to add more types and not have to do all of the boiler plate work of creating a project. The classes are so small I can't imagine they are going to add any significant impact to the size. |
|
@normj Going to do some testing on interface vs abstract class. Once I've completed I'll let you know what we find. As far as single project, that sounds great. It would be a lot easier for publishing to Nuget. I'm going to close this PR and reopen a new PR with the discussed changes. It will take a couple of days. |
Issue , if available:
Closes #16. You will have to bring your own class based on the data returned from your given trigger.
Description of changes:
Added missing class for Scheduled Events.
https://docs.aws.amazon.com/lambda/latest/dg/eventsources.html#eventsources-scheduled-event
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.