Corrected the data type for ClaimsToAddOrOverride property in IdTokenGeneration and AccessTokenGeneration classes for CognitoPreTokenGenerationV2Event. #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Generation and AccessTokenGeneration classes for CognitoPreTokenGenerationV2Event.
philasmar
reviewed
Aug 30, 2024
| @@ -6,7 +6,7 @@ | |||
| <Description>Amazon Lambda .NET Core support - CognitoEvents package.</Description> | |||
| <TargetFrameworks>netstandard2.0;netcoreapp3.1;net8.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Unrelated to the actual change, but since we're doing a major version bump, should we just drop netcoreapp3.1?
There was a problem hiding this comment.
I think we should. We still have handful of packages having netcoreapp3.1 target framework though.
@normj Please advise.
philasmar
approved these changes
Sep 3, 2024
normj
approved these changes
Sep 3, 2024
ashishdhingra
deleted the
user/ashdhin/CognitoPreTokenGenerationV2Event-Issue1798-Fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1798 (additional context #1792)
Description of changes:
Corrected the data type for
ClaimsToAddOrOverrideproperty inIdTokenGenerationandAccessTokenGenerationclasses forCognitoPreTokenGenerationV2Event.Per Pre token generation Lambda trigger, following is the event structure for
V2event:{ "request": { "userAttributes": { "string": "string" }, "scopes": ["string", "string"], "groupConfiguration": { "groupsToOverride": ["string", "string"], "iamRolesToOverride": ["string", "string"], "preferredRole": "string" }, "clientMetadata": { "string": "string" } }, "response": { "claimsAndScopeOverrideDetails": { "idTokenGeneration": { "claimsToAddOrOverride": { "string": [accepted datatype] }, "claimsToSuppress": ["string", "string"] }, "accessTokenGeneration": { "claimsToAddOrOverride": { "string": [accepted datatype] }, "claimsToSuppress": ["string", "string"], "scopesToAdd": ["string", "string"], "scopesToSuppress": ["string", "string"] }, "groupOverrideDetails": { "groupsToOverride": ["string", "string"], "iamRolesToOverride": ["string", "string"], "preferredRole": "string" } } } }Notice that
claimsToAddOrOverridefor bothidTokenGenerationandaccessTokenGenerationhas structure"string": [accepted datatype], where accepted datatype is one of the following:IMPORTANT: This is a breaking change and should be called out explicitly in CHANGELOG.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.