Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved F# templates #291

Merged
merged 11 commits into from Jul 9, 2018
Merged

Improved F# templates #291

merged 11 commits into from Jul 9, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 16, 2018

Issue #, if available: N/A

Description of changes:

This PR aims to improve the F# templates by:

  • formatting the code as recommended by the F# style guide;
  • using F# idiomatic constructs where appropriate.

Progress tracking:

  • Lambda Detect Image Labels
  • Lambda Empty Function
  • Lambda Simple DynamoDB Function
  • Lambda Simple Kinesis Function
  • Lambda Simple S3 Function
  • Lambda ASP.NET Core Web API
  • Serverless Detect Image Labels
  • Lambda Empty Serverless
  • Lambda Giraffe Web App
  • Serverless Simple S3 Function
  • Step Functions Hello World

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ghost ghost changed the title Fsharp style WIP: Improved F# templates Jun 16, 2018
@ghost
Copy link
Author

ghost commented Jun 16, 2018

My apologies for the nonsensical initial comment — my keyboard went wacky —, as well as for the many edits — for some reasons the Markdown preview was not working in my browser…

@normj
Copy link
Member

normj commented Jun 17, 2018

Awesome, I appreciate the help. My F# skills are at the learning stage. I'm traveling now but later this week I can take a deeper look into the changes.

@ghost
Copy link
Author

ghost commented Jun 18, 2018

No need to hurry, it will be some weeks before I finish reviewing all templates. Currently, my changes consist mostly in removing C# leftovers.

I am no F# expert but I'm glad if I can help. 🙂

@ghost ghost changed the title WIP: Improved F# templates Improved F# templates Jul 1, 2018
@ghost
Copy link
Author

ghost commented Jul 1, 2018

@normj There is still room for further improvements but I think I'm done with this PR, could you please review it?

@normj
Copy link
Member

normj commented Jul 4, 2018

Thanks I'll take a look soon. I'll have to merge it into another release we have coming very soon which affects the blueprints.

@normj normj merged commit 1ac9ef8 into aws:master Jul 9, 2018
@normj
Copy link
Member

normj commented Jul 9, 2018

Version 3.2.0 of Amazon.Lambda.Templates and version 1.14.4 of the AWS Toolkit for Visual Studio went out with these changes as part of today's .NET Core 2.1 release.

@ghost ghost deleted the fsharp-style branch July 9, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant