#521 Adjust handling of Default log category, adjusting it to .NET
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Core behavior
…parsing are in different order, it might have impact on default)
normj
approved these changes
Sep 20, 2019
|
Version 3.0.0 of Amazon.Lambda.Logging.AspNetCore has been released with the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust handling of
Defaultlog category, adjusting it to .NET Core behaviorRelated to #521
Description of changes:
Breaking change!
Defaultlogging category is set, it is used for loggers which don't match any configured categoryDefaultlogging category is not set,Informationis minimum level for categories not matching any config keySee #521 and/or unit tests for more details.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.