Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiGw websocket events #159

Merged
merged 15 commits into from
Feb 20, 2019
Merged

ApiGw websocket events #159

merged 15 commits into from
Feb 20, 2019

Conversation

spezam
Copy link
Contributor

@spezam spezam commented Jan 11, 2019

Support for ApiGw Websocket event.

fix: #154

@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #159   +/-   ##
======================================
  Coverage    69.8%   69.8%           
======================================
  Files          18      18           
  Lines         679     679           
======================================
  Hits          474     474           
  Misses        165     165           
  Partials       40      40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044197f...535a376. Read the comment docs.

@Dasio
Copy link

Dasio commented Jan 15, 2019

When WS Api gateway is using Authorize lambda function then field Authorizer in APIGatewayWebsocketProxyRequestContext is not string but map[string]interface{}

@spezam
Copy link
Contributor Author

spezam commented Jan 15, 2019

@Dasio doesn't sound very consistent.

How should we call the struct when used for Authorize? Any example from other Lambda SDKs?

@Dasio
Copy link

Dasio commented Jan 18, 2019

I'm not sure about other SDKs. Just saying what I observed when I was trying to implement WS with go.
Firstly without authorizer lambda function then field Authorizer is an empty string. But with using authorizer lambda function then it is Object with at least key principalId as string

@bmoffatt
Copy link
Collaborator

bmoffatt commented Jan 24, 2019

Was the event data in this PR and #154 generated from ex: docs, an example project? I'd like to play with the apparent inconsistencies.

@spezam
Copy link
Contributor Author

spezam commented Jan 25, 2019

@bmoffatt,
partially from the original ticket, but the best way was to setup an actual project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json: cannot unmarshal string into Go struct field APIGatewayProxyRequestContext.authorizer
5 participants