Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing NewNumberSetAttribute #167

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Add Missing NewNumberSetAttribute #167

merged 2 commits into from
Feb 20, 2019

Conversation

daviskoh
Copy link
Contributor

Changes:

  • add NewNumberSetAttribute
  • add test

Fixes #157

@codecov-io
Copy link

codecov-io commented Feb 12, 2019

Codecov Report

Merging #167 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage    69.8%   70.02%   +0.22%     
==========================================
  Files          18       18              
  Lines         679      684       +5     
==========================================
+ Hits          474      479       +5     
  Misses        165      165              
  Partials       40       40
Impacted Files Coverage Δ
events/attributevalue.go 82.8% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83699c...a9e2eea. Read the comment docs.

Copy link
Collaborator

@bmoffatt bmoffatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmoffatt bmoffatt merged commit ec2fec7 into aws:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants