-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Amazon MQ for RabbitMQ event structure #387
Conversation
Signed-off-by: Andrei Krasnitski <andrei.krasnitski@mendix.com>
4150941
to
dc5f286
Compare
@bmoffatt Could you please review this change. Thanks! |
events/rabbitmq.go
Outdated
Type *string `json:"type"` | ||
UserId string `json:"userId"` | ||
AppId *string `json:"appId"` | ||
ClusterId *string `json:"clusterId"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id
-> ID
everywhere
Really gotta get around to adding a linter rule for this, that's on me :)
type RabbitMQBasicProperties struct { | ||
ContentType string `json:"contentType"` | ||
ContentEncoding *string `json:"contentEncoding"` | ||
Headers map[string]interface{} `json:"headers"` // Application or header exchange table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to self to double check the docs - sample data makes it seem like this almost could have been defined as
type RabbitMQBasicProperties struct {
// ...
Headers map[string]RabbitMQBasicPropertiesHeaders `json:"headers"`
// ...
}
type RabbitMQBasicPropertiesHeaders struct {
Bytes []byte `json:"bytes"`
}
and it'd be nice if possible if a user didn't have to drop down into having to reflect over an interface{}
value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that the sample data was copy+paste from the docs, so I guess there's not much that can be done here
Codecov Report
@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 71.63% 71.63%
=======================================
Files 19 19
Lines 1040 1040
=======================================
Hits 745 745
Misses 228 228
Partials 67 67 Continue to review full report at Codecov.
|
Description of changes:
Adds Amazon MQ for RabbitMQ event structures.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.