-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add APIGatewayv2 Lambda Authorizer support in events #399
Conversation
Codecov Report
@@ Coverage Diff @@
## main #399 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 19 19
Lines 1050 1050
=======================================
Hits 750 750
Misses 232 232
Partials 68 68 Continue to review full report at Codecov.
|
@tjames-stig I see that the merge is blocked by a simple lint error, I hope you can find the time to fix it soon :-) |
This PR now passes my fork's workflows. |
added the test data from https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-lambda-authorizer.html |
Hi guys, forgive my ignorance and sorry for asking here but what is the release cycle? |
@menego I've just tagged v1.29.0, enjoy! |
Issue #, if available:
This addresses #394, which really is more of a symptom of not having purpose-built struct definitions for authorizers for HTTP API Gateway.
Description of changes:
apigw.go did not have any purpose-built struct definitions available for use for apigatewayv2 HTTP Lambda Authorizers, so I've added struct definitions for the V1 and V2 payloads for apigatewayv2 Lambda Authorizer requests, as well as the IAM Policy response payload.
I've tested the V2 request payload, as that is what I have code written in place for, but I have not yet tested the V1 request payload or the IAM policy response payload. For all struct definitions, I followed the documentation found at the http api lambda authorizer documentation.
I've attempted to reuse other structure definitions and follow what appeared to be the pre-existing naming convention for type names. I believe this is more or less what support for HTTP Lambda Authorizers should look like, but there will likely need to be some adjustments and tinkering made to naming and member ordering.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.