Add WithEnableSIGTERM option #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface emulator
Codecov Report
@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 72.90% 69.69% -3.22%
==========================================
Files 19 20 +1
Lines 1085 1201 +116
==========================================
+ Hits 791 837 +46
- Misses 225 297 +72
+ Partials 69 67 -2
Continue to review full report at Codecov.
|
carlzogh
reviewed
Jul 27, 2022
.github/workflows/tests.yml
Outdated
| @@ -25,11 +25,15 @@ jobs: | |||
|
|
|||
| - run: go version | |||
|
|
|||
| - name: install lambda runtime interface emulator | |||
| run: curl -L -o /usr/local/bin/aws-lambda-rie https://github.com/aws/aws-lambda-runtime-interface-emulator/releases/download/v1.6/aws-lambda-rie-x86_64 | |||
There was a problem hiding this comment.
change v1.6 to latest in order to always test against the most recent release - eg. URL from RIE readme:
https://github.com/aws/aws-lambda-runtime-interface-emulator/releases/latest/download/aws-lambda-rie-x86_64
There was a problem hiding this comment.
$ curl -L https://github.com/aws/aws-lambda-runtime-interface-emulator/releases/download/latest/aws-lambda-rie-x86_64
Not Found
There was a problem hiding this comment.
Oh oops no arch suffix for x86_64 apparently
There was a problem hiding this comment.
Actually it seems to be a different url ordering for latest
blahblah/latest/download/
Not
blahblah/download/latest/
🤷♂️
carlzogh
previously approved these changes
Jul 27, 2022
carlzogh
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#318
Description of changes:
Adds an incomplete internal implementation of the extensions API, and uses it to add an option to opt-in to SIGTERM. This allows function authors to run code on shutdown without also having to attach an extension layer.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.