-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support handlers that return io.Reader #472
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 69.69% 71.18% +1.49%
==========================================
Files 20 21 +1
Lines 1201 1253 +52
==========================================
+ Hits 837 892 +55
+ Misses 297 295 -2
+ Partials 67 66 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…overage to rpc mode logic
mergify bot
referenced
this pull request
in dbsystel/cdk-sops-secrets
Jan 9, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/aws/aws-lambda-go](https://github.com/aws/aws-lambda-go) | require | minor | `v1.36.1` -> `v1.37.0` | --- ### Release Notes <details> <summary>aws/aws-lambda-go</summary> ### [`v1.37.0`](https://github.com/aws/aws-lambda-go/releases/tag/v1.37.0) [Compare Source](https://github.com/aws/aws-lambda-go/compare/v1.36.1...v1.37.0) #### What's Changed - Support handlers that return io.Reader by [@​bmoffatt](https://github.com/bmoffatt) in [https://github.com/aws/aws-lambda-go/pull/472](https://github.com/aws/aws-lambda-go/pull/472) - Change the executable name in the README examples to `bootstrap` by [@​bmoffatt](https://github.com/bmoffatt) in [https://github.com/aws/aws-lambda-go/pull/476](https://github.com/aws/aws-lambda-go/pull/476) **Full Changelog**: aws/aws-lambda-go@v1.36.1...v1.37.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/markussiebert/cdk-sops-secrets).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#195
Description of changes:
Without this change, to return arbitrary non-json bytes, a user must write something like this
This works, but isn't perfect:
Invoke
With this change, the above handler can be re-written like:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.