-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: RSA key generation support #296
Comments
I have a branch for RSA OAEP support that also adds RSA key generation. I just need to rebase that branch and open a PR for the change. |
Merged
github-merge-queue bot
pushed a commit
to rustls/rcgen
that referenced
this issue
Jan 12, 2024
From the release 0.12 of rcgen #202 , we must now choose `ring` or `aws_lc_rc` as a feature. Because `rustls_cert_gen` has `default-features = false`, its build is currently broken. This PR activate `aws_lc_rc` feature, because soon it will get RSA key generation support aws/aws-lc-rs#296 , so it will provide more options. But we could also change it to default to whatever `rcgen` default or use `ring` as default depending on your preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem:
It looks as though aws-lc-rs shares the same API limitation as ring with respect to key generation being supported for EcdsaKeyPair and Ed25519KeyPair, but not RsaKeyPair.
As we're evaluating using aws-lc-rs as a backend for rcgen it would be really nice if aws-lc-rs supported RSA key generation. There's a class of use-case (e.g. Rustls' integration tests) where we have to use the
openssl
command line in order to generate RSA keypairs. Having support for this inrcgen
would make replacing that usage feasible.Solution:
aws-lc-rs could augment the
RsaKeyPair
struct to offer methods for generating a keypair comparable to those offered byEd25519KeyPair
andEcdsaKeyPair
.RsaKeyPair
struct would gain agenerate_pkcs8
and possibly agenerate_pkcs1
fns.Requirements / Acceptance Criteria:
It must be possible to generate an RSA keypair with both the public and private components. It should be convenient to load the serialized private key using the existing
RsaKeyPair::from_pkcs8
andRsaKeyPair::from_der
methods. Acceptance should look something like an end-to-end test generating a RSA keypair, loading it, using it to produce a signature, and then verifying the signature.aws_lc_rs
as crypto backend rustls/rcgen#201, Add RSA key generation briansmith/ring#219, [WIP]: Rsa keygen briansmith/ring#733The text was updated successfully, but these errors were encountered: