Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external bindgen for fips; more prefixing; bump aws-lc-fips-sys to v0.12.8 #388

Merged
merged 17 commits into from
Apr 25, 2024

Conversation

justsmth
Copy link
Contributor

Issues

Mostly Resolves: #366

Description of changes:

  • Bumps crate version to v0.12.8. Bindings generated in this run
  • Adds prefixing to symbols from rust_wrapper.c.
  • When no pre-generated bindings are available, build logic looks for and uses external bindgen executable for bindings generation.
  • Adds CI to test use of external bindgen.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the generate/aws-lc-fips-sys-v0.12.8 branch from 68dd225 to 33bc331 Compare April 11, 2024 15:47
@justsmth justsmth marked this pull request as ready for review April 11, 2024 16:01
@justsmth justsmth requested a review from a team as a code owner April 11, 2024 16:01
@samuel40791765 samuel40791765 self-requested a review April 16, 2024 17:35
@justsmth justsmth force-pushed the generate/aws-lc-fips-sys-v0.12.8 branch from b5e4f6b to 2b27964 Compare April 17, 2024 11:19
@justsmth justsmth changed the title Allow external bindgen for fips; Bump version to aws-lc-fips-sys v0.12.8 Allow external bindgen for fips; more prefixing; bump aws-lc-fips-sys to v0.12.8 Apr 17, 2024
@justsmth justsmth force-pushed the generate/aws-lc-fips-sys-v0.12.8 branch from d84d567 to abd8eb3 Compare April 18, 2024 17:47
aws-lc-fips-sys/builder/main.rs Outdated Show resolved Hide resolved
aws-lc-fips-sys/builder/main.rs Show resolved Hide resolved
skmcgrail
skmcgrail previously approved these changes Apr 18, 2024
aws-lc-fips-sys/include/rust_wrapper.h Outdated Show resolved Hide resolved
aws-lc-fips-sys/include/rust_wrapper.h Outdated Show resolved Hide resolved
@justsmth justsmth force-pushed the generate/aws-lc-fips-sys-v0.12.8 branch from 9e9adf2 to 23823e6 Compare April 22, 2024 21:01
samuel40791765
samuel40791765 previously approved these changes Apr 22, 2024
@justsmth justsmth merged commit 46582fd into aws:main Apr 25, 2024
169 of 172 checks passed
@justsmth justsmth deleted the generate/aws-lc-fips-sys-v0.12.8 branch August 28, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to guide on bindgen requirement
4 participants